Review Request 128249: Add switch to disable KParts' handling of window titles
Andreas Cord-Landwehr
cordlandwehr at kde.org
Thu Jun 23 19:05:50 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128249/
-----------------------------------------------------------
(Updated Juni 23, 2016, 7:05 nachm.)
Review request for KDE Frameworks, David Faure and Kevin Funk.
Changes
-------
Update patch according to David's suggestion
Repository: kparts
Description
-------
Applications that use several KParts, like KDevelop, want to do the
window title settings themselves. To enable that without causing a
flickering of the KParts' title and the application's title, an
explicit switch is required, since simply removing the setWindowTitle
connection after executing a KParts::MainWindow::createGUI(...) call still
causes an initial flickering, when the GUIActivateEvent is sent in
the createGUI method. Sending such an event should stay in the createGUI
method, though.
Diffs (updated)
-----
src/mainwindow.h 61a92e3
src/mainwindow.cpp be0b7dd
Diff: https://git.reviewboard.kde.org/r/128249/diff/
Testing
-------
Thanks,
Andreas Cord-Landwehr
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160623/5817c3ba/attachment.html>
More information about the Kde-frameworks-devel
mailing list