Review Request 128249: Add switch to disable KParts' handling of window titles

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128249/#review96772
-----------------------------------------------------------



Rest LGTM


src/mainwindow.cpp (line 81)
<https://git.reviewboard.kde.org/r/128249/#comment65362>

    Turn boolean parameter into enum maybe?
    
    E.g.:
    
    ```
    enum CreationFlag
    {
        ManageWindowTitle = 0 << 1
    }
    Q_DECLARE_FLAGS(CreationFlag, CreationFlags)
    
    void createGUI(Part*, CreationFlags flags);
    ```
    
    Makes the user code a bit easier to read.


- Kevin Funk


On June 19, 2016, 12:35 p.m., Andreas Cord-Landwehr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128249/
> -----------------------------------------------------------
> 
> (Updated June 19, 2016, 12:35 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Kevin Funk.
> 
> 
> Repository: kparts
> 
> 
> Description
> -------
> 
> Applications that use several KParts, like KDevelop, want to do the
> window title settings themselves. To enable that without causing a
> flickering of the KParts' title and the application's title, an
> explicit switch is required, since simply removing the setWindowTitle
> connection after executing a KParts::MainWindow::createGUI(...) call still
> causes an initial flickering, when the GUIActivateEvent is sent in
> the createGUI method. Sending such an event should stay in the createGUI
> method, though.
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.h 61a92e32e638c187253ba9e2cf0d8a410e9966af 
>   src/mainwindow.cpp be0b7ddc637d509f4c8191134096e365616ab38a 
> 
> Diff: https://git.reviewboard.kde.org/r/128249/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160621/8c6af541/attachment.html>