<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128249/">https://git.reviewboard.kde.org/r/128249/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Would it be better to just have a setter and a member bool for this? It's unlikely that we need some calls to set the title and some to not set it, so this way the setting is set once and for all (and the purpose of the bool is readable from the method name) - and this typically scales better than methods with many args.</p></pre>
<br />
<p>- David Faure</p>
<br />
<p>On June 19th, 2016, 12:35 p.m. UTC, Andreas Cord-Landwehr wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, David Faure and Kevin Funk.</div>
<div>By Andreas Cord-Landwehr.</div>
<p style="color: grey;"><i>Updated June 19, 2016, 12:35 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kparts
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Applications that use several KParts, like KDevelop, want to do the
window title settings themselves. To enable that without causing a
flickering of the KParts' title and the application's title, an
explicit switch is required, since simply removing the setWindowTitle
connection after executing a KParts::MainWindow::createGUI(...) call still
causes an initial flickering, when the GUIActivateEvent is sent in
the createGUI method. Sending such an event should stay in the createGUI
method, though.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/mainwindow.h <span style="color: grey">(61a92e32e638c187253ba9e2cf0d8a410e9966af)</span></li>
<li>src/mainwindow.cpp <span style="color: grey">(be0b7ddc637d509f4c8191134096e365616ab38a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128249/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>