Review Request 112828: Provide ecm_add_unit_test() and ecm_add_multiple_unit_tests()

[Alexander Neundorf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112828/#review40365
-----------------------------------------------------------


If it is good enough to be used in all frameworks in tier1/, and maybe more, then I'm for adding that.
Whether it is "auto" or "unit" test, I don't care that much.
In KF5 a test which runs on "make test" is an "autotest".
The other tests are more example programs.

In cmake language, only these "autotests" are tests, since only they have been added via add_test().
The other "tests" are for cmake just some executables.

e-c-m is not part of part of KF5, otherwise it would be the one "tier0" package. From my POV, it is an add-on package to cmake, which happens to be useful to KDE. So IMO it doesn't matter much how these tests are called in KF5.

But all that is just my opinion, I leave it to Stephen to decide.


- Alexander Neundorf


On Sept. 19, 2013, 3:57 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112828/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2013, 3:57 p.m.)
> 
> 
> Review request for Extra Cmake Modules and KDE Frameworks.
> 
> 
> Description
> -------
> 
> Add a new functions to add unit tests
> 
> Every framework in KF5 has a macro similar to these, this reduces
> the unnecessary duplication inside all of the frameworks
> 
> 
> Diffs
> -----
> 
>   modules/ECMAddUnitTest.cmake PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112828/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130919/f8e099dd/attachment.html>