Review Request 112828: Provide ecm_add_unit_test() and ecm_add_multiple_unit_tests()

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112828/#review40523
-----------------------------------------------------------



modules/ECMAddUnitTest.cmake
<http://git.reviewboard.kde.org/r/112828/#comment29833>

    I agree, it's about "automated" (vs "manual") tests here. We've no way when writing this macro to know if the user will make an automated unit test or integration test or...



modules/ECMAddUnitTest.cmake
<http://git.reviewboard.kde.org/r/112828/#comment29834>

    I'd argue that "multiple_" isn't necessary here as we're using a plural form already.


- Kevin Ottens


On Sept. 19, 2013, 3:57 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112828/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2013, 3:57 p.m.)
> 
> 
> Review request for Extra Cmake Modules and KDE Frameworks.
> 
> 
> Description
> -------
> 
> Add a new functions to add unit tests
> 
> Every framework in KF5 has a macro similar to these, this reduces
> the unnecessary duplication inside all of the frameworks
> 
> 
> Diffs
> -----
> 
>   modules/ECMAddUnitTest.cmake PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112828/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130923/f1b917bd/attachment-0001.html>