<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112828/">http://git.reviewboard.kde.org/r/112828/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If it is good enough to be used in all frameworks in tier1/, and maybe more, then I'm for adding that.
Whether it is "auto" or "unit" test, I don't care that much.
In KF5 a test which runs on "make test" is an "autotest".
The other tests are more example programs.
In cmake language, only these "autotests" are tests, since only they have been added via add_test().
The other "tests" are for cmake just some executables.
e-c-m is not part of part of KF5, otherwise it would be the one "tier0" package. From my POV, it is an add-on package to cmake, which happens to be useful to KDE. So IMO it doesn't matter much how these tests are called in KF5.
But all that is just my opinion, I leave it to Stephen to decide.
</pre>
<br />
<p>- Alexander</p>
<br />
<p>On September 19th, 2013, 3:57 p.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Extra Cmake Modules and KDE Frameworks.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Sept. 19, 2013, 3:57 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add a new functions to add unit tests
Every framework in KF5 has a macro similar to these, this reduces
the unnecessary duplication inside all of the frameworks</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>modules/ECMAddUnitTest.cmake <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112828/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>