Review Request 112828: Provide ecm_add_unit_test() and ecm_add_multiple_unit_tests()

Aleix Pol Gonzalez aleixpol at kde.org
Thu Sep 19 16:03:14 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112828/#review40360
-----------------------------------------------------------


It should be called autotests instead of unittests. It's the nomenclature we're using so far in KF5.
Additionally, an executable has many unit tests inside.

- Aleix Pol Gonzalez


On Sept. 19, 2013, 3:57 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112828/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2013, 3:57 p.m.)
> 
> 
> Review request for Extra Cmake Modules and KDE Frameworks.
> 
> 
> Description
> -------
> 
> Add a new functions to add unit tests
> 
> Every framework in KF5 has a macro similar to these, this reduces
> the unnecessary duplication inside all of the frameworks
> 
> 
> Diffs
> -----
> 
>   modules/ECMAddUnitTest.cmake PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112828/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130919/dc09ed15/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list