Review Request 113500: make KNewStuff build on its own

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113500/#review42829
-----------------------------------------------------------


Looks sane to me, and definitely an improvement, but see my comment.  It would be good to have a "ship it" from either Stephen Kelly or Alex Neundorf, though.


tier3/knewstuff/CMakeLists.txt
<http://git.reviewboard.kde.org/r/113500/#comment30979>

    Is it necessary to list *all* these, or can we just list the ones that are explicitly linked against in src/CMakeLists.txt (ie: XmlGui, KIO, KArchive, KI18n, ItemViews, KIconThemes, KTextWidgets)?


- Alex Merry


On Oct. 30, 2013, 3:41 p.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113500/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2013, 3:41 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> With these changes, KNewStuff can build on it's own and as part of kdelibs.
> 
> 
> Diffs
> -----
> 
>   tier3/knewstuff/CMakeLists.txt 497ab8d92622f917b6f37e1a58f62645ed298b2c 
>   tier3/knewstuff/src/CMakeLists.txt 0cdfe43608397b756aba80dcc9c47c7ddf398d66 
> 
> Diff: http://git.reviewboard.kde.org/r/113500/diff/
> 
> 
> Testing
> -------
> 
> Builds by itself and as part of kdelibs.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131102/dbd2ece4/attachment-0001.html>