Review Request 113500: make KNewStuff build on its own

[Jeremy Whiting]

> On Nov. 2, 2013, 7 a.m., Alex Merry wrote:
> > tier3/knewstuff/CMakeLists.txt, lines 15-19
> > <http://git.reviewboard.kde.org/r/113500/diff/2/?file=206509#file206509line15>
> >
> >     Is it necessary to list *all* these, or can we just list the ones that are explicitly linked against in src/CMakeLists.txt (ie: XmlGui, KIO, KArchive, KI18n, ItemViews, KIconThemes, KTextWidgets)?

I just rebased this change on upstream frameworks and it conflicts again, apparently the way we find KF5 keeps changing. My rebase currently doesn't even complete cmake since KF5Config.cmake and kf5-config.cmake can't be found. What is the "right" way to make stuff build standalone this week? Also why does it need to change every week? :)


- Jeremy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113500/#review42829
-----------------------------------------------------------


On Oct. 30, 2013, 9:41 a.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113500/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2013, 9:41 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> With these changes, KNewStuff can build on it's own and as part of kdelibs.
> 
> 
> Diffs
> -----
> 
>   tier3/knewstuff/CMakeLists.txt 497ab8d92622f917b6f37e1a58f62645ed298b2c 
>   tier3/knewstuff/src/CMakeLists.txt 0cdfe43608397b756aba80dcc9c47c7ddf398d66 
> 
> Diff: http://git.reviewboard.kde.org/r/113500/diff/
> 
> 
> Testing
> -------
> 
> Builds by itself and as part of kdelibs.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131102/43dab37f/attachment.html>