<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113500/">http://git.reviewboard.kde.org/r/113500/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks sane to me, and definitely an improvement, but see my comment. It would be good to have a "ship it" from either Stephen Kelly or Alex Neundorf, though.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113500/diff/2/?file=206509#file206509line15" style="color: black; font-weight: bold; text-decoration: underline;">tier3/knewstuff/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">14</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">CMake</span> <span class="s">Compiler</span> <span class="s">InstallDirs</span> <span class="s">KCoreAddons</span> <span class="s">KConfig</span> <span class="s">KI18n</span> <span class="s">KGuiAddons</span> <span class="s">KCodecs</span><span class="ew"> </span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">15</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">CMake</span> <span class="s">Compiler</span> <span class="s">InstallDirs</span> <span class="s">KCoreAddons</span> <span class="s">KConfig</span> <span class="s">KI18n</span> <span class="s">KGuiAddons</span> <span class="s">KCodecs</span><span class="ew"> </span></pre></td>
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">15</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">KWidgetsAddons</span> <span class="s">KAuth</span> <span class="s">ItemViews</span> <span class="s">KConfigWidgets</span> <span class="s">KArchive</span> <span class="s">KCompletion</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">16</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">KWidgetsAddons</span> <span class="s">KAuth</span> <span class="s">ItemViews</span> <span class="s">KConfigWidgets</span> <span class="s">KArchive</span> <span class="s">KCompletion</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">16</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">KIconThemes</span> <span class="s">KWindowSystem</span> <span class="s">KDBusAddons</span> <span class="s">KService</span> <span class="s">KJobWidgets</span> <span class="s"><span class="hl">KIO</span></span><span class="hl"> </span><span class="s">Sonnet</span><span class="ew"> </span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">17</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">KIconThemes</span> <span class="s">KWindowSystem</span> <span class="s">KDBusAddons</span> <span class="s">KService</span> <span class="s">KJobWidgets</span> <span class="s">Sonnet</span><span class="ew"> </span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">17</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">KTextWidgets</span> <span class="s">XmlGui</span> <span class="s">KCrash</span> <span class="s">KNotifications</span> <span class="s">KUnitConversion</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">18</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">KTextWidgets</span> <span class="s">XmlGui</span> <span class="s">KCrash</span> <span class="s">KNotifications</span> <span class="s">KUnitConversion</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">18</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">Solid</span> <span class="s">KWallet</span> <span class="s">KBookmarks</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">19</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">Solid</span> <span class="s">KWallet</span> <span class="s">KBookmarks</span><span class="hl"> </span><span class="s"><span class="hl">KIO</span></span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is it necessary to list *all* these, or can we just list the ones that are explicitly linked against in src/CMakeLists.txt (ie: XmlGui, KIO, KArchive, KI18n, ItemViews, KIconThemes, KTextWidgets)?</pre>
</div>
<br />
<p>- Alex Merry</p>
<br />
<p>On October 30th, 2013, 3:41 p.m. UTC, Jeremy Whiting wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Jeremy Whiting.</div>
<p style="color: grey;"><i>Updated Oct. 30, 2013, 3:41 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">With these changes, KNewStuff can build on it's own and as part of kdelibs.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds by itself and as part of kdelibs.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier3/knewstuff/CMakeLists.txt <span style="color: grey">(497ab8d92622f917b6f37e1a58f62645ed298b2c)</span></li>
<li>tier3/knewstuff/src/CMakeLists.txt <span style="color: grey">(0cdfe43608397b756aba80dcc9c47c7ddf398d66)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113500/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>