Review Request 113393: Get KPassivePopup positioning in a semi-working state

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113393/
-----------------------------------------------------------

(Updated Nov. 2, 2013, 12:46 p.m.)


Status
------

This change has been discarded.


Review request for KDE Frameworks.


Repository: kdelibs


Description
-------

Get KPassivePopup positioning in a semi-working state

Since we cannot use the NETWM stuff from KWindowSystems, we are forced
to either rely on what Qt can give us or hack in window-system-specific
code.  This does the former, using QDesktopWidget to calculate the
default placement of the popup, QWidget to place the popup next to our
own windows and QWindow for foreign windows.

Caveats:
* the docs claim the popup will be placed next to taskbar entries; this
  is not possible using only what Qt gives us
* Qt does not provide foreign window geometry on X11, so if you pass a
  foreign window id you will just get the default placement


Diffs
-----

  tier1/kwidgetsaddons/CMakeLists.txt ea6654d83acb265a87ed21c913a7f799b457ca71 
  tier1/kwidgetsaddons/src/kpassivepopup.cpp 663f63af413b7660c9c1b21af3e3ae4d7c424bbe 
  tier1/kwidgetsaddons/tests/kpassivepopuptest.cpp 4e7138523bdbe4166bf0e899d39d9ae1f8b8b447 

Diff: http://git.reviewboard.kde.org/r/113393/diff/


Testing
-------

Builds.  Test application seems to work as expected (on X11, at least).


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131102/3aea221b/attachment.html>