[Kde-finance-apps] Re: problem while committing

[puneet goyal]

> - I ran astyle which formatted some code. Please update your sandbox from
> svn
> to get those changes in formatting.
>
I think I had changed it that time, so I ran the astyle again and updated it


>
> - Please add more description to the alkuser object. What is is good for
> and
> what's its purpose? I am not sure what the attributes should be used for,
> so I
> can't really comment on it. Same for keyusermanager.  Maybe, the lack of
> comments is the source for all my questions below.
>
>

> - The DTOR of AlkUser does not delete the private 'd' memory. This will
> result
> in memory leaks.
>
>
deleted the memory in the destructor of the AlkUser itself

> - What is 'Q_String'? Please use QString as type in alkuser.cpp
>
> - The line
>
>  class ALK_EXport AlkUser : public QObject
>
> in alkuser.h should read
>
>  class ALK_EXPORT AlkUser : public QObject
>
> to work properly.
>
>
> updated

Regards,
Puneet
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-finance-apps/attachments/20110711/71d72463/attachment.htm