<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
- I ran astyle which formatted some code. Please update your sandbox from svn<br>
to get those changes in formatting.<br></blockquote><div>I think I had changed it that time, so I ran the astyle again and updated it <br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
- Please add more description to the alkuser object. What is is good for and<br>
what's its purpose? I am not sure what the attributes should be used for, so I<br>
can't really comment on it. Same for keyusermanager. Maybe, the lack of<br>
comments is the source for all my questions below.<br>
<br></blockquote><div> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
- The DTOR of AlkUser does not delete the private 'd' memory. This will result<br>
in memory leaks.<br>
<br></blockquote><div>deleted the memory in the destructor of the AlkUser itself <br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
- What is 'Q_String'? Please use QString as type in alkuser.cpp<br>
<br>
- The line<br>
<br>
class ALK_EXport AlkUser : public QObject<br>
<br>
in alkuser.h should read<br>
<br>
class ALK_EXPORT AlkUser : public QObject<br>
<br>
to work properly.<br>
<br>
<br></blockquote><div>updated<br><br>Regards,<br>Puneet<br>
</div></div>