[Kde-finance-apps] Re: problem while committing

[Thomas Baumgart]

Hi,

on Sunday 10 July 2011 21:32:13 puneet goyal wrote:

> > - I ran astyle which formatted some code. Please update your sandbox from
> > svn
> > to get those changes in formatting.
> 
> I think I had changed it that time, so I ran the astyle again and updated
> it
> 
> > - Please add more description to the alkuser object. What is is good for
> > and
> > what's its purpose? I am not sure what the attributes should be used for,
> > so I
> > can't really comment on it. Same for keyusermanager.  Maybe, the lack of
> > comments is the source for all my questions below.
> > 
> > 
> > 
> > - The DTOR of AlkUser does not delete the private 'd' memory. This will
> > result
> > in memory leaks.
> 
> deleted the memory in the destructor of the AlkUser itself
> 
> > - What is 'Q_String'? Please use QString as type in alkuser.cpp
> > 
> > - The line
> > 
> >  class ALK_EXport AlkUser : public QObject
> > 
> > in alkuser.h should read
> > 
> >  class ALK_EXPORT AlkUser : public QObject
> > 
> > to work properly.
> > 
> > 
> > updated

By looking at the code I have one question: did you ever compile the code you 
committed and how did you do it?

-- 

Regards

Thomas Baumgart

GPG-FP: E55E D592 F45F 116B 8429   4F99 9C59 DB40 B75D D3BA
-------------------------------------------------------------
If you pay peanuts, you'll get monkeys.
-------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 225 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/kde-finance-apps/attachments/20110710/e21d1e5b/attachment.sig