Review Request 122443: Add VocabularyModel

[Inge Wallin]

> On Feb. 6, 2015, 9:33 p.m., Peter Hedlund wrote:
> > Will other edu programs be ported to this class? The idea of a library is to have shared code. Also please make sure that other programs than Parley that use libkeduvocdocument do not break from this change.
> 
> Inge Wallin wrote:
>     Yes, they will.  The library itself is already being used by several other programs.  These item models could be used by any program, but are taken from Parley right now so are actually not at this time. There is no risk of any breakage in libkeduvocdocument because we are not touching that code.
> 
> Peter Hedlund wrote:
>     I know. I was one of the original creators of this library. Has it not been KDE policy that at least two programs should use code before it's put in a library?

I know that too (you being the author :) ).  But the actual reason why we are moving these models is because we are going to move the vocdocument editor from Parley to the library.  And that will be used by several applications.  


Regarding the policy, it's a bit of a chicken and egg problem. We either have to duplicate the code first and then put it into the library or we have to put it into the library with only one current user and then add it to the other applications. When it comes to the editor that is so big that it doesn't make sense to duplicate. 

Also, it is perhaps not obvious but this review is only a review for adding a class to a branch. The actual merging into the library will be preceeded by another review.


- Inge


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122443/#review75543
-----------------------------------------------------------


On Feb. 6, 2015, 9:04 p.m., Rahul Chowdhury wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122443/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2015, 9:04 p.m.)
> 
> 
> Review request for KDE Edu and Inge Wallin.
> 
> 
> Repository: libkeduvocdocument
> 
> 
> Description
> -------
> 
> Add a new KEduVocVocabularyModel class from Parley and change all code related to Parley and Prefs.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 44e1950 
>   keduvocdocument/CMakeLists.txt 6eeba12 
>   keduvocdocument/keduvocvocabularymodel.h PRE-CREATION 
>   keduvocdocument/keduvocvocabularymodel.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122443/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rahul Chowdhury
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150206/d2b3e3cb/attachment.html>