Review Request 122443: Add VocabularyModel

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122443/#review75565
-----------------------------------------------------------

Ship it!


Looks good now.  Just some very few issues. Fix them and then commit.


keduvocdocument/keduvocvocabularymodel.cpp
<https://git.reviewboard.kde.org/r/122443/#comment52273>

    You should probably provide a constructor that clears the private class. All members should be reset.



keduvocdocument/keduvocvocabularymodel.cpp
<https://git.reviewboard.kde.org/r/122443/#comment52274>

    This should go into the constructor of the private class.



keduvocdocument/keduvocvocabularymodel.cpp
<https://git.reviewboard.kde.org/r/122443/#comment52275>

    don't forget 'delete d', or you will get a memory leak.


- Inge Wallin


On Feb. 6, 2015, 9:04 p.m., Rahul Chowdhury wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122443/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2015, 9:04 p.m.)
> 
> 
> Review request for KDE Edu and Inge Wallin.
> 
> 
> Repository: libkeduvocdocument
> 
> 
> Description
> -------
> 
> Add a new KEduVocVocabularyModel class from Parley and change all code related to Parley and Prefs.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 44e1950 
>   keduvocdocument/CMakeLists.txt 6eeba12 
>   keduvocdocument/keduvocvocabularymodel.h PRE-CREATION 
>   keduvocdocument/keduvocvocabularymodel.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122443/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rahul Chowdhury
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150207/5a759d0f/attachment.html>