Review Request 122443: Add VocabularyModel

[Peter Hedlund]

> On Feb. 6, 2015, 8:33 p.m., Peter Hedlund wrote:
> > Will other edu programs be ported to this class? The idea of a library is to have shared code. Also please make sure that other programs than Parley that use libkeduvocdocument do not break from this change.
> 
> Inge Wallin wrote:
>     Yes, they will.  The library itself is already being used by several other programs.  These item models could be used by any program, but are taken from Parley right now so are actually not at this time. There is no risk of any breakage in libkeduvocdocument because we are not touching that code.

I know. I was one of the original creators of this library. Has it not been KDE policy that at least two programs should use code before it's put in a library?


- Peter


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122443/#review75543
-----------------------------------------------------------


On Feb. 6, 2015, 8:04 p.m., Rahul Chowdhury wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122443/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2015, 8:04 p.m.)
> 
> 
> Review request for KDE Edu and Inge Wallin.
> 
> 
> Repository: libkeduvocdocument
> 
> 
> Description
> -------
> 
> Add a new KEduVocVocabularyModel class from Parley and change all code related to Parley and Prefs.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 44e1950 
>   keduvocdocument/CMakeLists.txt 6eeba12 
>   keduvocdocument/keduvocvocabularymodel.h PRE-CREATION 
>   keduvocdocument/keduvocvocabularymodel.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122443/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rahul Chowdhury
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150206/a4e56ab4/attachment.html>