<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122443/">https://git.reviewboard.kde.org/r/122443/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 6th, 2015, 9:33 p.m. CET, <b>Peter Hedlund</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Will other edu programs be ported to this class? The idea of a library is to have shared code. Also please make sure that other programs than Parley that use libkeduvocdocument do not break from this change.</p></pre>
</blockquote>
<p>On February 6th, 2015, 9:37 p.m. CET, <b>Inge Wallin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, they will. The library itself is already being used by several other programs. These item models could be used by any program, but are taken from Parley right now so are actually not at this time. There is no risk of any breakage in libkeduvocdocument because we are not touching that code.</p></pre>
</blockquote>
<p>On February 6th, 2015, 10 p.m. CET, <b>Peter Hedlund</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I know. I was one of the original creators of this library. Has it not been KDE policy that at least two programs should use code before it's put in a library?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I know that too (you being the author :) ). But the actual reason why we are moving these models is because we are going to move the vocdocument editor from Parley to the library. And that will be used by several applications. </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Regarding the policy, it's a bit of a chicken and egg problem. We either have to duplicate the code first and then put it into the library or we have to put it into the library with only one current user and then add it to the other applications. When it comes to the editor that is so big that it doesn't make sense to duplicate. </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also, it is perhaps not obvious but this review is only a review for adding a class to a branch. The actual merging into the library will be preceeded by another review.</p></pre>
<br />
<p>- Inge</p>
<br />
<p>On February 6th, 2015, 9:04 p.m. CET, Rahul Chowdhury wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Edu and Inge Wallin.</div>
<div>By Rahul Chowdhury.</div>
<p style="color: grey;"><i>Updated Feb. 6, 2015, 9:04 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkeduvocdocument
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add a new KEduVocVocabularyModel class from Parley and change all code related to Parley and Prefs.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(44e1950)</span></li>
<li>keduvocdocument/CMakeLists.txt <span style="color: grey">(6eeba12)</span></li>
<li>keduvocdocument/keduvocvocabularymodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>keduvocdocument/keduvocvocabularymodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122443/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>