Review Request: konqueror: reset URL when pressing ESC in address bar

[Dawit A]

There is one particular issue with this patch. When you first start
konqueror, the introduction page is shown with a blank location bar. If you
then simply press escape in location bar, the location bar switches to
"about:konqueror" because that is the url of the current view. Perhaps the
patch needs to take care to avoid doing that ?

On Tue, Jun 21, 2011 at 8:49 AM, David Faure <faure at kde.org> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6681/
>
> Looks good, apart from some details.
>
>
>    /trunk/KDE/kdebase/apps/konqueror/src/konqmainwindow.cpp<http://svn.reviewboard.kde.org/r/6681/diff/2/?file=46511#file46511line3142> (Diff
> revision 2)
>
> bool KonqMainWindow::eventFilter(QObject*obj, QEvent *ev)
>
>    3142
>
>           KUrl url(m_currentView->url());
>
>   I think this should be m_currentView->locationBarURL()
>
>
>    /trunk/KDE/kdebase/apps/konqueror/src/konqmainwindow.cpp<http://svn.reviewboard.kde.org/r/6681/diff/2/?file=46511#file46511line3143> (Diff
> revision 2)
>
> bool KonqMainWindow::eventFilter(QObject*obj, QEvent *ev)
>
>    3143
>
>           m_combo->setURL(url.isLocalFile() ? url.toLocalFile() : url.prettyUrl());
>
>   Use pathOrUrl() to do this in a single call.
>
>
> - David
>
> On June 21st, 2011, 11:26 a.m., Marcel Partap wrote:
>   Review request for kdelibs and David Faure.
> By Marcel Partap.
>
> *Updated June 21, 2011, 11:26 a.m.*
> Description
>
> Attempted patch to make konqueror reset the URL when escape is pressed in the address bar. For reasons beyond my grokledge does not always seem to work.
>
>   Testing
>
> see https://bugs.kde.org/show_bug.cgi?id=257841#c0
>
>   *Bugs: * 257841 <https://bugs.kde.org/show_bug.cgi?id=257841>
> Diffs
>
>    - /trunk/KDE/kdebase/apps/konqueror/src/konqmainwindow.cpp (1200388)
>
> View Diff <http://svn.reviewboard.kde.org/r/6681/diff/>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110621/bd711b6b/attachment.htm>