There is one particular issue with this patch. When you first start konqueror, the introduction page is shown with a blank location bar. If you then simply press escape in location bar, the location bar switches to "about:konqueror" because that is the url of the current view. Perhaps the patch needs to take care to avoid doing that ?<br>
<br><div class="gmail_quote">On Tue, Jun 21, 2011 at 8:49 AM, David Faure <span dir="ltr"><<a href="mailto:faure@kde.org">faure@kde.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div>
<div style="font-family:Verdana, Arial, Helvetica, Sans-Serif"><div class="im">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border:1px #c9c399 solid">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6681/" target="_blank">http://svn.reviewboard.kde.org/r/6681/</a>
</td>
</tr>
</tbody></table>
<br>
</div><pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Looks good, apart from some details.</pre>
<br>
<div>
<table width="100%" border="0" bgcolor="white" style="border:1px solid #C0C0C0;border-collapse:collapse">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom:1px solid #C0C0C0;font-size:9pt;padding:4px 8px;text-align:left">
<a href="http://svn.reviewboard.kde.org/r/6681/diff/2/?file=46511#file46511line3142" style="color:black;font-weight:bold;text-decoration:underline" target="_blank">/trunk/KDE/kdebase/apps/konqueror/src/konqmainwindow.cpp</a>
<span style="font-weight:normal">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color:#e4d9cb;padding:4px 8px;text-align:center">
<tr>
<td colspan="4"><pre style="font-size:8pt;line-height:140%;margin:0">bool KonqMainWindow::eventFilter(QObject*obj, QEvent *ev)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right:1px solid #C0C0C0" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size:8pt;line-height:140%;margin:0"></pre></td>
<th bgcolor="#b1ebb0" style="border-left:1px solid #C0C0C0;border-right:1px solid #C0C0C0" align="right"><font size="2">3142</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size:8pt;line-height:140%;margin:0"> <span>KUrl</span> <span>url</span><span>(</span><span>m_currentView</span><span>-></span><span>url</span><span>());</span></pre>
</td>
</tr>
</tbody>
</table>
<pre style="margin-left:2em;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">I think this should be m_currentView->locationBarURL()</pre>
</div>
<br>
<div>
<table width="100%" border="0" bgcolor="white" style="border:1px solid #C0C0C0;border-collapse:collapse">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom:1px solid #C0C0C0;font-size:9pt;padding:4px 8px;text-align:left">
<a href="http://svn.reviewboard.kde.org/r/6681/diff/2/?file=46511#file46511line3143" style="color:black;font-weight:bold;text-decoration:underline" target="_blank">/trunk/KDE/kdebase/apps/konqueror/src/konqmainwindow.cpp</a>
<span style="font-weight:normal">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color:#e4d9cb;padding:4px 8px;text-align:center">
<tr>
<td colspan="4"><pre style="font-size:8pt;line-height:140%;margin:0">bool KonqMainWindow::eventFilter(QObject*obj, QEvent *ev)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right:1px solid #C0C0C0" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size:8pt;line-height:140%;margin:0"></pre></td>
<th bgcolor="#b1ebb0" style="border-left:1px solid #C0C0C0;border-right:1px solid #C0C0C0" align="right"><font size="2">3143</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size:8pt;line-height:140%;margin:0"> <span>m_combo</span><span>-></span><span>setURL</span><span>(</span><span>url</span><span>.</span><span>isLocalFile</span><span>()</span> <span>?</span> <span>url</span><span>.</span><span>toLocalFile</span><span>()</span> <span>:</span> <span>url</span><span>.</span><span>prettyUrl</span><span>());</span></pre>
</td>
</tr>
</tbody>
</table>
<pre style="margin-left:2em;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Use pathOrUrl() to do this in a single call.</pre>
</div>
<br>
<p>- David</p><div class="im">
<br>
<p>On June 21st, 2011, 11:26 a.m., Marcel Partap wrote:</p>
</div><table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-repeat:repeat-x;border:1px black solid">
<tbody><tr>
<td><div class="im">
<div>Review request for kdelibs and David Faure.</div>
<div>By Marcel Partap.</div>
<p style="color:grey"><i>Updated June 21, 2011, 11:26 a.m.</i></p>
</div><h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1><div class="im">
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Attempted patch to make konqueror reset the URL when escape is pressed in the address bar. For reasons beyond my grokledge does not always seem to work.</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">see <a href="https://bugs.kde.org/show_bug.cgi?id=257841#c0" target="_blank">https://bugs.kde.org/show_bug.cgi?id=257841#c0</a></pre>
</td>
</tr>
</tbody></table>
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt;margin-top:1.5em">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=257841" target="_blank">257841</a>
</div>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
</div><div class="im"><ul style="margin-left:3em;padding-left:0">
<li>/trunk/KDE/kdebase/apps/konqueror/src/konqmainwindow.cpp <span style="color:grey">(1200388)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6681/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>
</div></td>
</tr>
</tbody></table>
</div>
</div>
</blockquote></div><br>