Review Request: konqueror: reset URL when pressing ESC in address bar

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6681/#review10245
-----------------------------------------------------------


Looks good, apart from some details.


/trunk/KDE/kdebase/apps/konqueror/src/konqmainwindow.cpp
<http://svn.reviewboard.kde.org/r/6681/#comment11818>

    I think this should be m_currentView->locationBarURL()



/trunk/KDE/kdebase/apps/konqueror/src/konqmainwindow.cpp
<http://svn.reviewboard.kde.org/r/6681/#comment11819>

    Use pathOrUrl() to do this in a single call.


- David


On June 21, 2011, 11:26 a.m., Marcel Partap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6681/
> -----------------------------------------------------------
> 
> (Updated June 21, 2011, 11:26 a.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Summary
> -------
> 
> Attempted patch to make konqueror reset the URL when escape is pressed in the address bar. For reasons beyond my grokledge does not always seem to work.
> 
> 
> This addresses bug 257841.
>     https://bugs.kde.org/show_bug.cgi?id=257841
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/apps/konqueror/src/konqmainwindow.cpp 1200388 
> 
> Diff: http://svn.reviewboard.kde.org/r/6681/diff
> 
> 
> Testing
> -------
> 
> see https://bugs.kde.org/show_bug.cgi?id=257841#c0
> 
> 
> Thanks,
> 
> Marcel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110621/efed3b46/attachment.htm>