Review Request: konqueror: reset URL when pressing ESC in address bar

[Marcel Partap]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6681/
-----------------------------------------------------------

(Updated June 21, 2011, 4:20 p.m.)


Review request for kdelibs and David Faure.


Changes
-------

> I think this should be m_currentView->locationBarURL()
Cannot be used, equals the combo box entry after tab change.

> If you then simply press escape in location bar, the location bar switches to "about:konqueror" because that is the url of the current view.
In fact, i'd consider that sane behaviour. However, it has been dealt with ;)

btw the code above the patch is defunct. Shouldn't it rather call slotNextTab()/slotPrevTab? no reverse CTRL+TABbing as of now.


Summary
-------

Attempted patch to make konqueror reset the URL when escape is pressed in the address bar. For reasons beyond my grokledge does not always seem to work.


This addresses bug 257841.
    https://bugs.kde.org/show_bug.cgi?id=257841


Diffs (updated)
-----

  /trunk/KDE/kdebase/apps/konqueror/src/konqmainwindow.cpp 1200388 

Diff: http://svn.reviewboard.kde.org/r/6681/diff


Testing
-------

see https://bugs.kde.org/show_bug.cgi?id=257841#c0


Thanks,

Marcel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110621/ce26c53a/attachment.htm>