Review Request: konqueror: reset URL when pressing ESC in address bar

Marcel Partap mpartap at
Tue Jun 21 17:20:11 BST 2011

This is an automatically generated e-mail. To reply, visit:

(Updated June 21, 2011, 4:20 p.m.)

Review request for kdelibs and David Faure.


> I think this should be m_currentView->locationBarURL()
Cannot be used, equals the combo box entry after tab change.

> If you then simply press escape in location bar, the location bar switches to "about:konqueror" because that is the url of the current view.
In fact, i'd consider that sane behaviour. However, it has been dealt with ;)

btw the code above the patch is defunct. Shouldn't it rather call slotNextTab()/slotPrevTab? no reverse CTRL+TABbing as of now.


Attempted patch to make konqueror reset the URL when escape is pressed in the address bar. For reasons beyond my grokledge does not always seem to work.

This addresses bug 257841.

Diffs (updated)

  /trunk/KDE/kdebase/apps/konqueror/src/konqmainwindow.cpp 1200388 






-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list