Review Request: Second Part of fixes for password caching in KIO: KPasswdServer

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101210/
-----------------------------------------------------------

(Updated April 24, 2011, 12:11 a.m.)


Review request for kdelibs and David Faure.


Summary
-------

The attached patch is the other half of the patch proposed in https://git.reviewboard.kde.org/r/101174/. It changes KPasswdServer to do the
following:

#1. If the extra field "skip-caching-on-query" is specified, then the queryAuthInfo* functions will not automatically store the password because the user checked the "Remember password" checkbox. This is essential for the changes made to SlaveBase::openPasswordDialog in

#2. A call to addAuthInfo will now save the specified password information in the wallet. It is bit surprising that addAuthInfo seems to only update and/or store the information in memory. This again ensures that calling SlaveBase::cacheAuthentication information will actually result in the password information being saved into the wallet.


Diffs
-----

  kpasswdserver/kpasswdserver.cpp 7330742 

Diff: http://git.reviewboard.kde.org/r/101210/diff


Testing
-------


Thanks,

Dawit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110424/a96f916a/attachment.htm>