Review Request: Second Part of fixes for password caching in KIO: KPasswdServer

Dawit Alemayehu adawit at
Sat Apr 23 15:59:52 BST 2011

This is an automatically generated e-mail. To reply, visit:

(Updated April 23, 2011, 2:59 p.m.)

Review request for kdelibs.

Summary (updated)

The attached patch is the other half of the patch proposed in It changes KPasswdServer to do the

#1. If the extra field "skip-caching-on-query" is specified, then the queryAuthInfo* functions will not automatically store the password because the user checked the "Remember password" checkbox. This is essential for the changes made to SlaveBase::openPasswordDialog in

#2. A call to addAuthInfo will now save the specified password information in the wallet. It is bit surprising that addAuthInfo seems to only update and/or store the information in memory. This again ensures that calling SlaveBase::cacheAuthentication information will actually result in the password information being saved into the wallet.


  kpasswdserver/kpasswdserver.cpp 7330742 





-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list