<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101210/">http://git.reviewboard.kde.org/r/101210/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated April 24, 2011, 12:11 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The attached patch is the other half of the patch proposed in https://git.reviewboard.kde.org/r/101174/. It changes KPasswdServer to do the
following:
#1. If the extra field "skip-caching-on-query" is specified, then the queryAuthInfo* functions will not automatically store the password because the user checked the "Remember password" checkbox. This is essential for the changes made to SlaveBase::openPasswordDialog in
#2. A call to addAuthInfo will now save the specified password information in the wallet. It is bit surprising that addAuthInfo seems to only update and/or store the information in memory. This again ensures that calling SlaveBase::cacheAuthentication information will actually result in the password information being saved into the wallet.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kpasswdserver/kpasswdserver.cpp <span style="color: grey">(7330742)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101210/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>