Review Request 129763: Undo a change to the API for create_sip which is not actually needed.

[Shaheed Haque]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129763/
-----------------------------------------------------------

(Updated Jan. 21, 2017, 3:31 p.m.)


Review request for Extra Cmake Modules.


Changes
-------

The question was raised (https://mail.kde.org/pipermail/kde-bindings/2017-January/008412.html) as to if this might actually affect the logic in ECM designed to handle cases such as kcoreaddons. So, apart from a mninor rebase, this change includes additional testing:

1. Against the new unit test in ECM added to handle the above.
2. Retesting against kguiaddons.
3. Verifying that kcoreaddons build as expected.

See details int he testing section of the revisions used.


Repository: extra-cmake-modules


Description
-------

The change broke the integration with the bulk testing tools, these
will be restored in a subsequent commit.


Diffs (updated)
-----

  find-modules/FindPythonModuleGeneration.cmake 012f806260e0d947ef6ebd50902813deaf24fb81 
  find-modules/sip_generator.py ba9dd636aeb1bf7345f87e5f05bcf530f53f2e2c 

Diff: https://git.reviewboard.kde.org/r/129763/diff/


Testing (updated)
-------

Rebased on current ECM master
=============================

$ git log
commit 6f2bdd753663b5bea97d716b5e7117f80dcc95a1
Author: Shaheed Haque <srhaque at theiet.org>
Date:   Tue Jan 3 14:27:57 2017 +0000

    Undo a change to the API for create_sip which is not actually needed.
    
    The change broke the integration with the bulk testing tools, these
    will be restored in a subsequent commit.

commit 3e6eb0562e5fd3831d66db4720c67cc950b3536c
Author: Stephen Kelly <steveire at gmail.com>
Date:   Wed Jan 18 23:31:17 2017 +0000

    Bindings: Test file in subdirectory.

First run ECM test:

$ make test
Running tests...
Test project /home/srhaque/kdebuild/extra-cmake-modules
      Start  1: GenerateSipBindings
 1/49 Test  #1: GenerateSipBindings ...................................   Passed   15.12 sec
      Start  2: ExecuteCoreModules
 2/49 Test  #2: ExecuteCoreModules ....................................   Passed    0.32 sec
      Start  3: ExecuteKDEModules

And then install:

$ sudo make install
...
-- Up-to-date: /usr/local/share/ECM/find-modules/GeneratePythonBindingUmbrellaModule.cmake
-- Up-to-date: /usr/local/share/ECM/find-modules/Qt5Ruleset.py
-- Up-to-date: /usr/local/share/ECM/find-modules/rules_engine.py
-- Up-to-date: /usr/local/share/ECM/find-modules/run-sip.py
-- Up-to-date: /usr/local/share/ECM/find-modules/sip_generator.py


Reverify current kguiaddons
===========================

$ git log
commit cb82278f0b4da446a7859873f3e99ca64c470552
Author: Kevin Funk <kfunk at kde.org>
Date:   Mon Jan 16 09:44:17 2017 +0100

    Use nullptr everywhere
    
    Differential Revision: https://phabricator.kde.org/D3987

$ make test
Running tests...
Test project /home/srhaque/kdebuild/kguiaddons
    Start 1: appstreamtest
1/6 Test #1: appstreamtest ....................   Passed    0.02 sec
    Start 2: Py3TestKGuiAddons
2/6 Test #2: Py3TestKGuiAddons ................   Passed    0.15 sec
    Start 3: Py2TestKGuiAddons
3/6 Test #3: Py2TestKGuiAddons ................   Passed    0.12 sec
    Start 4: kwordwraptest
4/6 Test #4: kwordwraptest ....................   Passed    0.17 sec
    Start 5: kcolorutilstest
5/6 Test #5: kcolorutilstest ..................   Passed    0.52 sec
    Start 6: kiconutilstest
6/6 Test #6: kiconutilstest ...................   Passed    0.08 sec

100% tests passed, 0 tests failed out of 6

Total Test time (real) =   1.08 sec


Verify kcoreaddons
==================

$ git log
commit f76c35dc2d9e9716f44b0eaacf42c34250e9f1cd
Author: Milian Wolff <mail at milianw.de>
Date:   Fri Jan 20 20:37:53 2017 +0100

    Mark some methods as const

$ make test
Running tests...
Test project /home/srhaque/kdebuild/kcoreaddons
      Start  1: appstreamtest
 1/26 Test  #1: appstreamtest ....................   Passed    0.02 sec
      Start  2: Py3TestKCoreAddons
 2/26 Test  #2: Py3TestKCoreAddons ...............   Passed    0.27 sec
      Start  3: Py2TestKCoreAddons
 3/26 Test  #3: Py2TestKCoreAddons ...............   Passed    0.26 sec
      Start  4: kaboutdatatest
 4/26 Test  #4: kaboutdatatest ...................***Failed    0.06 sec
      Start  5: kaboutdataapplicationdatatest
 5/26 Test  #5: kaboutdataapplicationdatatest ....   Passed    0.02 sec
      Start  6: kautosavefiletest


Thanks,

Shaheed Haque

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20170121/9b69bf6b/attachment.html>