Review Request 129763: Undo a change to the API for create_sip which is not actually needed.

[Shaheed Haque]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129763/
-----------------------------------------------------------

Review request for Extra Cmake Modules.


Repository: extra-cmake-modules


Description
-------

The change broke the integration with the bulk testing tools, these
will be restored in a subsequent commit.


Diffs
-----

  find-modules/FindPythonModuleGeneration.cmake 0a857a24b17d74ae34d2ca8062a274778895b2c2 
  find-modules/sip_generator.py 10be147711540437d38153fa8fe859bd34d7aa6c 

Diff: https://git.reviewboard.kde.org/r/129763/diff/


Testing
-------

Re-install and then re-run kguiaddons:

$ sudo make install
[sudo] password for srhaque: 
...
-- Installing: /usr/local/share/ECM/find-modules/FindPythonModuleGeneration.cmake
...
-- Installing: /usr/local/share/ECM/find-modules/sip_generator.py


$ make
...
[  1%] Generating sip/PyKF5/KGuiAddons/kcolorutils.sip
[  3%] Generating sip/PyKF5/KGuiAddons/kcolorcollection.sip
[  5%] Generating sip/PyKF5/KGuiAddons/kcolormimedata.sip
[  7%] Generating sip/PyKF5/KGuiAddons/kdatevalidator.sip
[  8%] Generating sip/PyKF5/KGuiAddons/kwordwrap.sip
[ 10%] Generating sip/PyKF5/KGuiAddons/kfontutils.sip
[ 12%] Generating sip/PyKF5/KGuiAddons/kiconutils.sip
[ 14%] Generating sip/PyKF5/KGuiAddons/kimagecache.sip
[ 16%] Generating sip/PyKF5/KGuiAddons/kmodifierkeyinfo.sip
[ 16%] Built target generate_KGuiAddons_sip_files
[ 17%] Generating pybuild/PyKF5/KGuiAddons/unifiedKGuiAddons.cpp
...

$ ctest
Test project /home/srhaque/kdebuild/kguiaddons
    Start 1: appstreamtest
1/6 Test #1: appstreamtest ....................   Passed    0.02 sec
    Start 2: Py3Test
2/6 Test #2: Py3Test ..........................   Passed    0.14 sec
    Start 3: Py2Test
3/6 Test #3: Py2Test ..........................   Passed    0.11 sec
    Start 4: kwordwraptest
4/6 Test #4: kwordwraptest ....................   Passed    0.16 sec
    Start 5: kcolorutilstest
5/6 Test #5: kcolorutilstest ..................   Passed    0.53 sec
    Start 6: kiconutilstest
6/6 Test #6: kiconutilstest ...................   Passed    0.08 sec

100% tests passed, 0 tests failed out of 6

Total Test time (real) =   1.04 sec


Thanks,

Shaheed Haque

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20170103/09ab53bb/attachment.html>