<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129763/">https://git.reviewboard.kde.org/r/129763/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Extra Cmake Modules.</div>
<div>By Shaheed Haque.</div>
<p style="color: grey;"><i>Updated Jan. 21, 2017, 3:31 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The question was raised (https://mail.kde.org/pipermail/kde-bindings/2017-January/008412.html) as to if this might actually affect the logic in ECM designed to handle cases such as kcoreaddons. So, apart from a mninor rebase, this change includes additional testing:</p>
<ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Against the new unit test in ECM added to handle the above.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Retesting against kguiaddons.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Verifying that kcoreaddons build as expected.</li>
</ol>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See details int he testing section of the revisions used.</p></pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The change broke the integration with the bulk testing tools, these
will be restored in a subsequent commit.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Rebased on current ECM master</h1>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">$ git log
commit 6f2bdd753663b5bea97d716b5e7117f80dcc95a1
Author: Shaheed Haque <a href="mailto:srhaque@theiet.org" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">srhaque@theiet.org</a>
Date: Tue Jan 3 14:27:57 2017 +0000</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span></span>Undo a change to the API for create_sip which is not actually needed.
The change broke the integration with the bulk testing tools, these
will be restored in a subsequent commit.
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">commit 3e6eb0562e5fd3831d66db4720c67cc950b3536c
Author: Stephen Kelly <a href="mailto:steveire@gmail.com" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">steveire@gmail.com</a>
Date: Wed Jan 18 23:31:17 2017 +0000</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span></span>Bindings<span style="color: #666666">:</span> Test file <span style="color: #008000; font-weight: bold">in</span> subdirectory<span style="color: #666666">.</span>
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">First run ECM test:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">$ make test
Running tests...
Test project /home/srhaque/kdebuild/extra-cmake-modules
Start 1: GenerateSipBindings
1/49 Test #1: GenerateSipBindings ................................... Passed 15.12 sec
Start 2: ExecuteCoreModules
2/49 Test #2: ExecuteCoreModules .................................... Passed 0.32 sec
Start 3: ExecuteKDEModules</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">And then install:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">$ sudo make install
...
-- Up-to-date: /usr/local/share/ECM/find-modules/GeneratePythonBindingUmbrellaModule.cmake
-- Up-to-date: /usr/local/share/ECM/find-modules/Qt5Ruleset.py
-- Up-to-date: /usr/local/share/ECM/find-modules/rules_engine.py
-- Up-to-date: /usr/local/share/ECM/find-modules/run-sip.py
-- Up-to-date: /usr/local/share/ECM/find-modules/sip_generator.py</p>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Reverify current kguiaddons</h1>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">$ git log
commit cb82278f0b4da446a7859873f3e99ca64c470552
Author: Kevin Funk <a href="mailto:kfunk@kde.org" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">kfunk@kde.org</a>
Date: Mon Jan 16 09:44:17 2017 +0100</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span></span>Use nullptr everywhere
Differential Revision: https://phabricator.kde.org/D3987
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">$ make test
Running tests...
Test project /home/srhaque/kdebuild/kguiaddons
Start 1: appstreamtest
1/6 Test #1: appstreamtest .................... Passed 0.02 sec
Start 2: Py3TestKGuiAddons
2/6 Test #2: Py3TestKGuiAddons ................ Passed 0.15 sec
Start 3: Py2TestKGuiAddons
3/6 Test #3: Py2TestKGuiAddons ................ Passed 0.12 sec
Start 4: kwordwraptest
4/6 Test #4: kwordwraptest .................... Passed 0.17 sec
Start 5: kcolorutilstest
5/6 Test #5: kcolorutilstest .................. Passed 0.52 sec
Start 6: kiconutilstest
6/6 Test #6: kiconutilstest ................... Passed 0.08 sec</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">100% tests passed, 0 tests failed out of 6</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Total Test time (real) = 1.08 sec</p>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Verify kcoreaddons</h1>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">$ git log
commit f76c35dc2d9e9716f44b0eaacf42c34250e9f1cd
Author: Milian Wolff <a href="mailto:mail@milianw.de" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">mail@milianw.de</a>
Date: Fri Jan 20 20:37:53 2017 +0100</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span></span>Mark some methods as const
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">$ make test
Running tests...
Test project /home/srhaque/kdebuild/kcoreaddons
Start 1: appstreamtest
1/26 Test #1: appstreamtest .................... Passed 0.02 sec
Start 2: Py3TestKCoreAddons
2/26 Test #2: Py3TestKCoreAddons ............... Passed 0.27 sec
Start 3: Py2TestKCoreAddons
3/26 Test #3: Py2TestKCoreAddons ............... Passed 0.26 sec
Start 4: kaboutdatatest
4/26 Test #4: kaboutdatatest ...................***Failed 0.06 sec
Start 5: kaboutdataapplicationdatatest
5/26 Test #5: kaboutdataapplicationdatatest .... Passed 0.02 sec
Start 6: kautosavefiletest</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>find-modules/FindPythonModuleGeneration.cmake <span style="color: grey">(012f806260e0d947ef6ebd50902813deaf24fb81)</span></li>
<li>find-modules/sip_generator.py <span style="color: grey">(ba9dd636aeb1bf7345f87e5f05bcf530f53f2e2c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129763/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>