Review Request 128806: Make KDECMakeSettings work with KDE_INSTALL_DIRS_NO_DEPRECATED

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128806/#review100591
-----------------------------------------------------------


Ship it!




Looks good to me. The flaw you mention seems to me like a feature. If someone uses GNUInstallDirs to define LIB_INSTALL_DIR, then that should be used, certainly. If someone uses both GNUInstallDirs and KDEInstallDirs+NO_DEPRECATED, then that someone is asking for trouble in any case, but obeying the more standard GNUInstallDirs doesn't seem like a bad thing to me.

- David Faure


On Aug. 31, 2016, 12:56 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128806/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2016, 12:56 a.m.)
> 
> 
> Review request for Extra Cmake Modules.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> The RPATH handling part of KDECMakeSettings.cmake relies on the var LIB_INSTALL_DIR,
> expecting to be used very often in combination with the KDEInstallDirs module which defines it,
> with the simple two-liner
> ```
> include(KDEInstallDirs)
> include(KDECMakeSettings)
> ```
> Though the variable LIB_INSTALL_DIR is one of the vars which is deprecated by the KDEInstallDirs module,
> in favour of the namespaced KDE_INSTALL_LIBDIR.
> And when using the KDE_INSTALL_DIRS_NO_DEPRECATED setting, to no longer have deprecated vars like LIB_INSTALL_DIR set (e.g. when integrating a non-ECM-CMake build subproject where the vars are conflicting), the nice cooperation between the two modules fails flat with a FATAL_ERROR. 
> 
> Which is annoying and should be fixed.
> 
> Existing 3rd-party code which might rely on LIB_INSTALL_DIR needs to be kept working. So LIB_INSTALL_DIR needs
> to be interpreted as before if existing. But if not existing, I propose to add the new official var KDE_INSTALL_LIBDIR
> to be used as fallback in KDECMakeSettings. That would unbreak the module cooperation on KDE_INSTALL_DIRS_NO_DEPRECATED.
> 
> Just, there is the small flaw that something else might be injecting LIB_INSTALL_DIR still,
> when otherwise KDE_INSTALL_DIRS_NO_DEPRECATED is set. Should we care about that?
> Any idea how and when best to deprecate using LIB_INSTALL_DIR with KDECMakeSettings?
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDECMakeSettings.cmake 46fd10a 
> 
> Diff: https://git.reviewboard.kde.org/r/128806/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20161105/4361762a/attachment.html>