<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128806/">https://git.reviewboard.kde.org/r/128806/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks good to me. The flaw you mention seems to me like a feature. If someone uses GNUInstallDirs to define LIB_INSTALL_DIR, then that should be used, certainly. If someone uses both GNUInstallDirs and KDEInstallDirs+NO_DEPRECATED, then that someone is asking for trouble in any case, but obeying the more standard GNUInstallDirs doesn't seem like a bad thing to me.</p></pre>
<br />
<p>- David Faure</p>
<br />
<p>On August 31st, 2016, 12:56 a.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Extra Cmake Modules.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Aug. 31, 2016, 12:56 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The RPATH handling part of KDECMakeSettings.cmake relies on the var LIB_INSTALL_DIR,
expecting to be used very often in combination with the KDEInstallDirs module which defines it,
with the simple two-liner</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span></span>include(KDEInstallDirs)
include(KDECMakeSettings)
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Though the variable LIB_INSTALL_DIR is one of the vars which is deprecated by the KDEInstallDirs module,
in favour of the namespaced KDE_INSTALL_LIBDIR.
And when using the KDE_INSTALL_DIRS_NO_DEPRECATED setting, to no longer have deprecated vars like LIB_INSTALL_DIR set (e.g. when integrating a non-ECM-CMake build subproject where the vars are conflicting), the nice cooperation between the two modules fails flat with a FATAL_ERROR. </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Which is annoying and should be fixed.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Existing 3rd-party code which might rely on LIB_INSTALL_DIR needs to be kept working. So LIB_INSTALL_DIR needs
to be interpreted as before if existing. But if not existing, I propose to add the new official var KDE_INSTALL_LIBDIR
to be used as fallback in KDECMakeSettings. That would unbreak the module cooperation on KDE_INSTALL_DIRS_NO_DEPRECATED.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Just, there is the small flaw that something else might be injecting LIB_INSTALL_DIR still,
when otherwise KDE_INSTALL_DIRS_NO_DEPRECATED is set. Should we care about that?
Any idea how and when best to deprecate using LIB_INSTALL_DIR with KDECMakeSettings?</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kde-modules/KDECMakeSettings.cmake <span style="color: grey">(46fd10a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128806/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>