Review Request 128112: New module: ecm_win_resolve_symlinks

Gleb Popov 6yearold at gmail.com
Sat Nov 5 14:40:28 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128112/
-----------------------------------------------------------

(Updated Nov. 5, 2016, 2:40 p.m.)


Status
------

This change has been marked as submitted.


Review request for Extra Cmake Modules and KDE Frameworks.


Changes
-------

Submitted with commit 632b8868de38e2f85fb4969bcae3dd89a2a0695c by Gleb Popov to branch master.


Repository: extra-cmake-modules


Description
-------

When git is checking out repositories with UNIX symbolic links inside on Windows machine, it writes them as plain text files, containing relative path to the real file. This is the case for breeze-icons framework, for instance, and this breaks some icons that are symlinked.

This macro is intended to fix that. There is some room for performance improvement, but i wanted to get the feedback early.


Diffs
-----

  modules/ECMWinResolveSymlinks.cmake PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/128112/diff/


Testing
-------


Thanks,

Gleb Popov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20161105/b0555275/attachment.html>


More information about the Kde-buildsystem mailing list