Review Request 128806: Make KDECMakeSettings work with KDE_INSTALL_DIRS_NO_DEPRECATED

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128806/
-----------------------------------------------------------

(Updated Nov. 5, 2016, 10:57 a.m.)


Status
------

This change has been marked as submitted.


Review request for Extra Cmake Modules.


Changes
-------

Submitted with commit b60f1116b2cf0401f52060d7bdf0c524b918d23a by Friedrich W. H. Kossebau to branch master.


Repository: extra-cmake-modules


Description
-------

The RPATH handling part of KDECMakeSettings.cmake relies on the var LIB_INSTALL_DIR,
expecting to be used very often in combination with the KDEInstallDirs module which defines it,
with the simple two-liner
```
include(KDEInstallDirs)
include(KDECMakeSettings)
```
Though the variable LIB_INSTALL_DIR is one of the vars which is deprecated by the KDEInstallDirs module,
in favour of the namespaced KDE_INSTALL_LIBDIR.
And when using the KDE_INSTALL_DIRS_NO_DEPRECATED setting, to no longer have deprecated vars like LIB_INSTALL_DIR set (e.g. when integrating a non-ECM-CMake build subproject where the vars are conflicting), the nice cooperation between the two modules fails flat with a FATAL_ERROR. 

Which is annoying and should be fixed.

Existing 3rd-party code which might rely on LIB_INSTALL_DIR needs to be kept working. So LIB_INSTALL_DIR needs
to be interpreted as before if existing. But if not existing, I propose to add the new official var KDE_INSTALL_LIBDIR
to be used as fallback in KDECMakeSettings. That would unbreak the module cooperation on KDE_INSTALL_DIRS_NO_DEPRECATED.

Just, there is the small flaw that something else might be injecting LIB_INSTALL_DIR still,
when otherwise KDE_INSTALL_DIRS_NO_DEPRECATED is set. Should we care about that?
Any idea how and when best to deprecate using LIB_INSTALL_DIR with KDECMakeSettings?


Diffs
-----

  kde-modules/KDECMakeSettings.cmake 46fd10a 

Diff: https://git.reviewboard.kde.org/r/128806/diff/


Testing
-------


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20161105/4d2b2ce2/attachment-0001.html>