Review Request 110664: Create metaplugins containing smaller plugins
Boudewijn Rempt
boud at valdyas.org
Fri Jun 7 12:04:54 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110664/
-----------------------------------------------------------
(Updated June 7, 2013, 11:04 a.m.)
Status
------
This change has been discarded.
Review request for Calligra.
Description
-------
On Windows, at least, loading the libraries and plugins causes a huge slowdown on startup. On Android, having lots of dynamic libraries isn't supported either. This patch defines a CMake option (METAPLUGIN) that makes it possible to optionally compile a set of plugins into a single plugin, like shown here for the Krita filters.
See http://wstaw.org/w/1XpB/ for a screendump of vtune on Windows.
Diffs
-----
CMakeLists.txt d5782b4
krita/plugins/filters/CMakeLists.txt 31fbc8c
krita/plugins/filters/colorsfilters/colorsfilters.h 217d3e9
krita/plugins/filters/colorsfilters/colorsfilters.cpp 54fd60e
krita/plugins/filters/colorsfilters/colorsfiltersplugin.h PRE-CREATION
krita/plugins/filters/colorsfilters/colorsfiltersplugin.cpp PRE-CREATION
krita/plugins/filters/convolutionfilters/CMakeLists.txt 4abcdff
krita/plugins/filters/convolutionfilters/convolutionfilters.h e92add0
krita/plugins/filters/convolutionfilters/convolutionfilters.cpp 7097f5f
krita/plugins/filters/convolutionfilters/convolutionfiltersplugin.h PRE-CREATION
krita/plugins/filters/convolutionfilters/convolutionfiltersplugin.cpp PRE-CREATION
krita/plugins/filters/example/example.h e33ac65
krita/plugins/filters/example/example.cpp 89cf65a
krita/plugins/filters/fastcolortransfer/fastcolortransfer.h bf668d5
krita/plugins/filters/fastcolortransfer/fastcolortransfer.cpp 56196e6
krita/plugins/filters/kritametafilter.desktop PRE-CREATION
krita/plugins/filters/metafilter.cpp PRE-CREATION
krita/plugins/filters/noisefilter/noisefilter.h 551b6f9
krita/plugins/filters/noisefilter/noisefilter.cpp 5656d5b
krita/plugins/filters/randompickfilter/CMakeLists.txt 327327f
krita/plugins/filters/randompickfilter/randompickfilter.h ac04ec9
krita/plugins/filters/randompickfilter/randompickfilter.cpp acce712
krita/plugins/filters/randompickfilter/randompickfilterplugin.h PRE-CREATION
krita/plugins/filters/randompickfilter/randompickfilterplugin.cpp PRE-CREATION
krita/plugins/filters/wavefilter/wavefilter.h 94f4373
krita/plugins/filters/wavefilter/wavefilter.cpp 3c9c81e
Diff: http://git.reviewboard.kde.org/r/110664/diff/
Testing
-------
Thanks,
Boudewijn Rempt
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130607/82dfc600/attachment.htm>
More information about the calligra-devel
mailing list