Review Request 110595: Remove get-prefix from getResourceByName/getAssignedTagsList/getTagNamesList method names
Commit Hook
null at kde.org
Fri Jun 7 20:38:20 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110595/#review33917
-----------------------------------------------------------
This review has been submitted with commit 4c438d1306790efc7849bc9453fe28ac2c5e59c6 by Friedrich W. H. Kossebau to branch master.
- Commit Hook
On May 22, 2013, 3:19 p.m., Friedrich W. H. Kossebau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110595/
> -----------------------------------------------------------
>
> (Updated May 22, 2013, 3:19 p.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> get-prefix is not very Qt-ish, so I would propose to remove some more for consistency.
>
>
> Diffs
> -----
>
> libs/widgets/tests/KoResourceTagging_test.cpp 9100e7a
> libs/widgets/KoResourceTagging.cpp b678000
> libs/widgets/KoResourceTagging.h 0624096
> libs/widgets/KoResourceServerProvider.cpp 64e5fde
> libs/widgets/KoResourceServerAdapter.h 02ab31e
> libs/widgets/KoResourceModel.cpp a9cb212
> libs/widgets/KoResourceServer.h 1ab4ad6
> libs/widgets/KoResourceModel.h 3ccb28b
> libs/widgets/KoResourceItemChooser.cpp a2750b5
> libs/widgets/KoResourceItemChooser.h d26f5a5
> krita/ui/widgets/kis_preset_chooser.cpp 9f07c8a
> krita/ui/widgets/kis_preset_chooser.h 5df3b56
> krita/ui/kis_paintop_box.cc 61c0d12
> krita/ui/ko_favorite_resource_manager.cpp 2481ce1
> krita/plugins/paintops/libpaintop/kis_brush_based_paintop_settings.cpp 389bd9f
> krita/plugins/paintops/libbrush/kis_svg_brush_factory.cpp 9833a6d
> krita/plugins/paintops/libbrush/kis_gbr_brush_factory.cpp fe52a42
> krita/plugins/paintops/libbrush/kis_png_brush_factory.cpp 0a2d25e
> krita/plugins/paintops/libbrush/kis_abr_brush_factory.cpp 34e7264
> krita/plugins/extensions/dockers/defaultdockers/kis_palette_docker.cc c61eb54
> krita/plugins/extensions/bigbrother/bigbrother.cc f59e55e
>
> Diff: http://git.reviewboard.kde.org/r/110595/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Friedrich W. H. Kossebau
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130607/fd21aad8/attachment.htm>
More information about the calligra-devel
mailing list