<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110664/">http://git.reviewboard.kde.org/r/110664/</a>
     </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
 <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Calligra.</div>
<div>By Boudewijn Rempt.</div>


<p style="color: grey;"><i>Updated June 7, 2013, 11:04 a.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">On Windows, at least, loading the libraries and plugins causes a huge slowdown on startup. On Android, having lots of dynamic libraries isn't supported either. This patch defines a CMake option (METAPLUGIN) that makes it possible to optionally compile a set of plugins into a single plugin, like shown here for the Krita filters.

See http://wstaw.org/w/1XpB/ for a screendump of vtune on Windows.</pre>
  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(d5782b4)</span></li>

 <li>krita/plugins/filters/CMakeLists.txt <span style="color: grey">(31fbc8c)</span></li>

 <li>krita/plugins/filters/colorsfilters/colorsfilters.h <span style="color: grey">(217d3e9)</span></li>

 <li>krita/plugins/filters/colorsfilters/colorsfilters.cpp <span style="color: grey">(54fd60e)</span></li>

 <li>krita/plugins/filters/colorsfilters/colorsfiltersplugin.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>krita/plugins/filters/colorsfilters/colorsfiltersplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>krita/plugins/filters/convolutionfilters/CMakeLists.txt <span style="color: grey">(4abcdff)</span></li>

 <li>krita/plugins/filters/convolutionfilters/convolutionfilters.h <span style="color: grey">(e92add0)</span></li>

 <li>krita/plugins/filters/convolutionfilters/convolutionfilters.cpp <span style="color: grey">(7097f5f)</span></li>

 <li>krita/plugins/filters/convolutionfilters/convolutionfiltersplugin.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>krita/plugins/filters/convolutionfilters/convolutionfiltersplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>krita/plugins/filters/example/example.h <span style="color: grey">(e33ac65)</span></li>

 <li>krita/plugins/filters/example/example.cpp <span style="color: grey">(89cf65a)</span></li>

 <li>krita/plugins/filters/fastcolortransfer/fastcolortransfer.h <span style="color: grey">(bf668d5)</span></li>

 <li>krita/plugins/filters/fastcolortransfer/fastcolortransfer.cpp <span style="color: grey">(56196e6)</span></li>

 <li>krita/plugins/filters/kritametafilter.desktop <span style="color: grey">(PRE-CREATION)</span></li>

 <li>krita/plugins/filters/metafilter.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>krita/plugins/filters/noisefilter/noisefilter.h <span style="color: grey">(551b6f9)</span></li>

 <li>krita/plugins/filters/noisefilter/noisefilter.cpp <span style="color: grey">(5656d5b)</span></li>

 <li>krita/plugins/filters/randompickfilter/CMakeLists.txt <span style="color: grey">(327327f)</span></li>

 <li>krita/plugins/filters/randompickfilter/randompickfilter.h <span style="color: grey">(ac04ec9)</span></li>

 <li>krita/plugins/filters/randompickfilter/randompickfilter.cpp <span style="color: grey">(acce712)</span></li>

 <li>krita/plugins/filters/randompickfilter/randompickfilterplugin.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>krita/plugins/filters/randompickfilter/randompickfilterplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>krita/plugins/filters/wavefilter/wavefilter.h <span style="color: grey">(94f4373)</span></li>

 <li>krita/plugins/filters/wavefilter/wavefilter.cpp <span style="color: grey">(3c9c81e)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110664/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>