Review Request: StatSyncing GSoC week 12 (squashed commits, recent on top)

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105979/
-----------------------------------------------------------

Review request for Amarok, Bart Cerneels and Myriam Schweingruber.


Description
-------

StatSyncing: support for writing tags, rating to Last.fm

plus some clean-ups to lastfm SynchronizationAdapter

StatSyncing: core support for synchronizing labels


StatSyncing: don't suck when offering fields to synchronize

....and include those that are writeable by lone provider, too.

StatSyncing: don't add The::mainWindow() as parent of statsyncing dialog

...because it makes the mainWindow look inactive.

StatSyncing: support for matching Last.fm tracks

Yay! We even read play count and tags!

StatSyncing: match tracks case-insensitively

I can hardly imagine that different case distinguishes different songs

StatSyncing: export Provider and Track

...so that they can be used outside of amaroklib

StatSyncing: polish the UI to (near) perfection

Provide 2-way button links between configuration and actual
synchronization, add icons to buttons, simplify text, make the UI more
clean, add tooltips...

StatSyncing: fix broken track matching due to QSharedPointer -> QSharedDataPointer

Caused by QExplicitlyShatedDataPointer not providing operator<.
Reported to Qt as https://bugreports.qt-project.org/browse/QTBUG-26805

StatSyncing::Controller: full tracking of Providers

...makes config dialog update to changed, added and removed providers


Diffs
-----

  src/configdialog/dialogs/MetadataConfig.ui PRE-CREATION 
  src/configdialog/dialogs/MetadataConfig.cpp PRE-CREATION 
  src/services/lastfm/CMakeLists.txt 637afd4111d720904e41a94be51c9b71fa01221f 
  src/services/lastfm/LastFmService.h ac13d41cc5fd626a3ed6cb306d0969ef320c0c09 
  src/services/lastfm/LastFmService.cpp a14d989b3fac81e545df095adee36580b052fea7 
  src/services/lastfm/SynchronizationAdapter.h PRE-CREATION 
  src/services/lastfm/SynchronizationAdapter.cpp PRE-CREATION 
  src/services/lastfm/SynchronizationTrack.h PRE-CREATION 
  src/services/lastfm/SynchronizationTrack.cpp PRE-CREATION 
  src/statsyncing/Controller.h PRE-CREATION 
  src/statsyncing/Controller.cpp PRE-CREATION 
  src/statsyncing/Process.cpp PRE-CREATION 
  src/statsyncing/Provider.h PRE-CREATION 
  src/statsyncing/Provider.cpp PRE-CREATION 
  src/statsyncing/Track.h PRE-CREATION 
  src/statsyncing/Track.cpp PRE-CREATION 
  src/statsyncing/TrackTuple.h PRE-CREATION 
  src/statsyncing/TrackTuple.cpp PRE-CREATION 
  src/statsyncing/collection/CollectionProvider.h PRE-CREATION 
  src/statsyncing/collection/CollectionProvider.cpp PRE-CREATION 
  src/statsyncing/jobs/MatchTracksJob.cpp PRE-CREATION 
  src/statsyncing/models/CommonModel.cpp PRE-CREATION 
  src/statsyncing/models/MatchedTracksModel.cpp PRE-CREATION 
  src/statsyncing/models/ProvidersModel.h PRE-CREATION 
  src/statsyncing/models/ProvidersModel.cpp PRE-CREATION 
  src/statsyncing/ui/ChooseProvidersPage.h PRE-CREATION 
  src/statsyncing/ui/ChooseProvidersPage.cpp PRE-CREATION 
  src/statsyncing/ui/ChooseProvidersPage.ui PRE-CREATION 
  src/statsyncing/ui/MatchedTracksPage.h PRE-CREATION 
  src/statsyncing/ui/MatchedTracksPage.cpp PRE-CREATION 
  src/statsyncing/ui/TrackDelegate.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/105979/diff/


Testing
-------


Thanks,

Matěj Laitl

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120811/58dc6d8e/attachment.html>