Review Request: GSoC report: Integrate Spotify into Amarok #4 (squashed commits, recent on top)

[Zhengliang Feng]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105285/
-----------------------------------------------------------

(Updated Aug. 13, 2012, 11:24 a.m.)


Review request for Amarok.


Changes
-------

Now the Spotify collection has a configuration dialog, all basic features are done except playlist synchronization.
Updates:
* Add a capability action for configuration dialog, and it works well.
* Automatically download resolver program from remote server if it's not found in local system.
* Remove KCModule code

Todo:
* Continue polishing Querymaker
* Clean up unnecessary code and add more documentation
* Finish playlist support

Screenshots:
[1] http://i.imgur.com/uh0KI.png
[2] http://i.imgur.com/uLgmG.png
[3] http://i.imgur.com/tFy3W.png


Description
-------

Things I've done this week:
* Added a new playlist provider SpotifyPlaylistProvider
* Added playlist class SpotifyPlaylist
* Clear all extra whitespaces
* Figured out how Collection, QueryMaker and Playlist worked

Things need to be done next week:
* Clean ScriptResolver's interfaces, move all query related interfaces into Query class
* Replace Controller class with ScriptResolver
* Test SpotifyCollection
* Finish playlist and playlist provider


Diffs (updated)
-----

  src/core-impl/collections/CMakeLists.txt c78b920 
  src/core-impl/collections/spotifycollection/CMakeLists.txt PRE-CREATION 
  src/core-impl/collections/spotifycollection/SpotifyCollection.h PRE-CREATION 
  src/core-impl/collections/spotifycollection/SpotifyCollection.cpp PRE-CREATION 
  src/core-impl/collections/spotifycollection/SpotifyConfig.h PRE-CREATION 
  src/core-impl/collections/spotifycollection/SpotifyConfig.cpp PRE-CREATION 
  src/core-impl/collections/spotifycollection/SpotifyConfigWidget.ui PRE-CREATION 
  src/core-impl/collections/spotifycollection/SpotifyMeta.h PRE-CREATION 
  src/core-impl/collections/spotifycollection/SpotifyMeta.cpp PRE-CREATION 
  src/core-impl/collections/spotifycollection/SpotifyPlaylist.h PRE-CREATION 
  src/core-impl/collections/spotifycollection/SpotifyPlaylist.cpp PRE-CREATION 
  src/core-impl/collections/spotifycollection/SpotifyPlaylistProvider.h PRE-CREATION 
  src/core-impl/collections/spotifycollection/SpotifyPlaylistProvider.cpp PRE-CREATION 
  src/core-impl/collections/spotifycollection/SpotifyQueryMaker.h PRE-CREATION 
  src/core-impl/collections/spotifycollection/SpotifyQueryMaker.cpp PRE-CREATION 
  src/core-impl/collections/spotifycollection/SpotifySettings.h PRE-CREATION 
  src/core-impl/collections/spotifycollection/SpotifySettings.cpp PRE-CREATION 
  src/core-impl/collections/spotifycollection/amarok_collection-spotifycollection.desktop PRE-CREATION 
  src/core-impl/collections/spotifycollection/support/Controller.h PRE-CREATION 
  src/core-impl/collections/spotifycollection/support/Controller.cpp PRE-CREATION 
  src/core-impl/collections/spotifycollection/support/QMFunctionTypes.h PRE-CREATION 
  src/core-impl/collections/spotifycollection/support/Query.h PRE-CREATION 
  src/core-impl/collections/spotifycollection/support/Query.cpp PRE-CREATION 
  src/core-impl/collections/spotifycollection/support/TrackProxy.h PRE-CREATION 
  src/core-impl/collections/spotifycollection/support/TrackProxy.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/105285/diff/


Testing
-------

No test done this week. 


Thanks,

Zhengliang Feng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120813/c1def4bf/attachment.html>