<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105979/">http://git.reviewboard.kde.org/r/105979/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok, Bart Cerneels and Myriam Schweingruber.</div>
<div>By Matěj Laitl.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">StatSyncing: support for writing tags, rating to Last.fm
plus some clean-ups to lastfm SynchronizationAdapter
StatSyncing: core support for synchronizing labels
StatSyncing: don't suck when offering fields to synchronize
....and include those that are writeable by lone provider, too.
StatSyncing: don't add The::mainWindow() as parent of statsyncing dialog
...because it makes the mainWindow look inactive.
StatSyncing: support for matching Last.fm tracks
Yay! We even read play count and tags!
StatSyncing: match tracks case-insensitively
I can hardly imagine that different case distinguishes different songs
StatSyncing: export Provider and Track
...so that they can be used outside of amaroklib
StatSyncing: polish the UI to (near) perfection
Provide 2-way button links between configuration and actual
synchronization, add icons to buttons, simplify text, make the UI more
clean, add tooltips...
StatSyncing: fix broken track matching due to QSharedPointer -> QSharedDataPointer
Caused by QExplicitlyShatedDataPointer not providing operator<.
Reported to Qt as https://bugreports.qt-project.org/browse/QTBUG-26805
StatSyncing::Controller: full tracking of Providers
...makes config dialog update to changed, added and removed providers</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/configdialog/dialogs/MetadataConfig.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/configdialog/dialogs/MetadataConfig.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/lastfm/CMakeLists.txt <span style="color: grey">(637afd4111d720904e41a94be51c9b71fa01221f)</span></li>
<li>src/services/lastfm/LastFmService.h <span style="color: grey">(ac13d41cc5fd626a3ed6cb306d0969ef320c0c09)</span></li>
<li>src/services/lastfm/LastFmService.cpp <span style="color: grey">(a14d989b3fac81e545df095adee36580b052fea7)</span></li>
<li>src/services/lastfm/SynchronizationAdapter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/lastfm/SynchronizationAdapter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/lastfm/SynchronizationTrack.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/lastfm/SynchronizationTrack.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/Controller.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/Controller.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/Process.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/Provider.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/Provider.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/Track.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/Track.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/TrackTuple.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/TrackTuple.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/collection/CollectionProvider.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/collection/CollectionProvider.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/jobs/MatchTracksJob.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/models/CommonModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/models/MatchedTracksModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/models/ProvidersModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/models/ProvidersModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/ui/ChooseProvidersPage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/ui/ChooseProvidersPage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/ui/ChooseProvidersPage.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/ui/MatchedTracksPage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/ui/MatchedTracksPage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/ui/TrackDelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105979/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>