Equalizer support in Amarok - patch

[Nikolaj Hald Nielsen]

Hi Artur.

I finally managed to get Amarok to play sounds again so I could actually
test your patch.

First of all: wow, well done, it actually works! :-)

I have a few comments:

I don't know if this belongs in the settings menu, I am thinking it would
fit better under "tools", but this is up for discussion. Also, we obviously
need a dialog for manually configuring levels. And then people would likely
want to be able to save their own custom presets as well, so there are a lot
of things to disuss and work on here! :-)

And then, as you yourself mention, there are some pretty significant
clipping in both the trebble especially the bass in some of the presets. I
am thinking that it might make sense to perhaps limit the range a little, as
it seems like we are really going beyound xines abilities with some
settings?

Anyway, keep up the good work, many people will be very happy to get this
feature back!

- Nikolaj



On Mon, Jul 20, 2009 at 10:58 AM, Artur Szymiec <artur.szymiec at gmail.com>wrote:

>  Hello,
>
> a small update regarding issue with audio distortion and sound differences
> between audacious original
> equalizer and my implementation for phonon xine backend:
>
> - the bug has been fixed in phonon trunk svn (as of revision r999575).
> - the sound is now 99.999% same like in audacious with the same equalizer
> settings (compared byte by byte output for same wave input file)
>   (the remaining 0.001 is that decoding engine is different then xine and
> that at present phonon kequalizer doesn't support dithering - whatever I'll
> add it
>    or now it's not clear now).
>
> Hope that somebody with a good hearing (not me certainly :))) will find
> time to tune the presets to match current equalizer characteristic.
>
> So happy testing ;)
>
> Artur
>
>
> Current issues:
> - equalizer presets where imported from previous Amarok series with small
> adjustments to prevent clipping noise
> - because equalizer code in phonon is quite different from that in xine lib
> in 1.4 series we need to find a good default presets that doesn't cause a
> clipping - any volunteers ?
>   (Actually the code is adopted from audacious player - the reason why  in
> Audacious clipping doesn't occur with pretty much same setting for same
>    audio clip is under my investigation. Whatever it can be resolved I'm
> not sure about it - there are so many differences between xine and audacious
> starting
>    from different decoder code to internal data handling format - int vs
> float).
>
>
>
>    Omnes Vulnerant Postuma Necat ...
> --------------------------------------------------------------------------
> Registered User No 397465
> GNU/Linux Linux 2.6.28-12-generic x86_64
> (K)/(U)buntu 9.04
> --------------------------------------------------------------------------
>
>
>
> _______________________________________________
> Amarok-devel mailing list
> Amarok-devel at kde.org
> https://mail.kde.org/mailman/listinfo/amarok-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20090720/4625ddf3/attachment.htm