Hi Artur.<br><br>I finally managed to get Amarok to play sounds again so I could actually test your patch.<br><br>First of all: wow, well done, it actually works! :-)<br><br>I have a few comments:<br><br>I don't know if this belongs in the settings menu, I am thinking it would fit better under "tools", but this is up for discussion. Also, we obviously need a dialog for manually configuring levels. And then people would likely want to be able to save their own custom presets as well, so there are a lot of things to disuss and work on here! :-)<br>
<br>And then, as you yourself mention, there are some pretty significant clipping in both the trebble especially the bass in some of the presets. I am thinking that it might make sense to perhaps limit the range a little, as it seems like we are really going beyound xines abilities with some settings?<br>
<br>Anyway, keep up the good work, many people will be very happy to get this feature back!<br><br>- Nikolaj<br><br><br><br><div class="gmail_quote">On Mon, Jul 20, 2009 at 10:58 AM, Artur Szymiec <span dir="ltr"><<a href="mailto:artur.szymiec@gmail.com">artur.szymiec@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div>
Hello,<br>
<br>
a small update regarding issue with audio distortion and sound differences between audacious original<br>
equalizer and my implementation for phonon xine backend:<br>
<br>
- the bug has been fixed in phonon trunk svn (as of revision r999575).<br>
- the sound is now 99.999% same like in audacious with the same equalizer settings (compared byte by byte output for same wave input file)<br>
(the remaining 0.001 is that decoding engine is different then xine and that at present phonon kequalizer doesn't support dithering - whatever I'll add it<br>
or now it's not clear now).<br>
<br>
Hope that somebody with a good hearing (not me certainly :))) will find time to tune the presets to match current equalizer characteristic.<br>
<br>
So happy testing ;)<br><font color="#888888">
<br>
Artur</font><div class="im"><br>
<br>
<blockquote type="CITE">
<br>
Current issues:<br>
- equalizer presets where imported from previous Amarok series with small adjustments to prevent clipping noise<br>
- because equalizer code in phonon is quite different from that in xine lib in 1.4 series we need to find a good default presets that doesn't cause a clipping - any volunteers ?<br>
(Actually the code is adopted from audacious player - the reason why in Audacious clipping doesn't occur with pretty much same setting for same<br>
audio clip is under my investigation. Whatever it can be resolved I'm not sure about it - there are so many differences between xine and audacious starting<br>
from different decoder code to internal data handling format - int vs float).<br>
<br>
</blockquote>
<table cellpadding="0" cellspacing="0" width="100%">
<tbody><tr>
<td>
<br>
<br>
</td>
</tr>
</tbody></table>
</div><div class="im"><table cellpadding="0" cellspacing="0" width="100%">
<tbody><tr>
<td>
Omnes Vulnerant Postuma Necat ...<br>
--------------------------------------------------------------------------<br>
Registered User No 397465<br>
GNU/Linux Linux 2.6.28-12-generic x86_64<br>
(K)/(U)buntu 9.04<br>
--------------------------------------------------------------------------<br>
<br>
<br>
</td>
</tr>
</tbody></table>
</div></div>
<br>_______________________________________________<br>
Amarok-devel mailing list<br>
<a href="mailto:Amarok-devel@kde.org">Amarok-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/amarok-devel" target="_blank">https://mail.kde.org/mailman/listinfo/amarok-devel</a><br>
<br></blockquote></div><br>