[WebKit-devel] KDE WebKit status update [Remix]
Urs Wolfer
uwolfer at kde.org
Sat Oct 17 21:02:46 CEST 2009
On Thursday 15 October 2009 20:29:17 Dawit A. wrote:
> On Thursday 15 October 2009 11:36:26 Michael Howell wrote:
[..]
> > class AccessManager {
> > ...
> > };
> > namespace NetworkIntegration {
> > typedef KIO::AccessManager AccessManager;
> > ...
> > }
>
> That is exactly what I did... I guess I will create a reviewboard request
> to get this included for 4.3.3 since the patch is trivial enough addition,
> but of a great deal help to cleaning up kdewebkit and making it ready for
> kdereview.
Why have you put everything into one file? I prefer one public class per file.
Otherwise I agree with your patch.
Bye
urs
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/webkit-devel/attachments/20091017/f5154041/attachment.sig
More information about the WebKit-devel
mailing list