[WebKit-devel] KDE WebKit status update [Remix]

[Dawit A.]

On Saturday 17 October 2009 15:02:46 Urs Wolfer wrote:
> On Thursday 15 October 2009 20:29:17 Dawit A. wrote:
> > On Thursday 15 October 2009 11:36:26 Michael Howell wrote:
> 
> [..]
> 
> > > class AccessManager {
> > > ...
> > > };
> > > namespace NetworkIntegration {
> > > typedef KIO::AccessManager AccessManager;
> > > ...
> > > }
> >
> > That is exactly what I did... I guess I will create a reviewboard request
> >  to get this included for 4.3.3 since the patch is trivial enough
> > addition, but of a great deal help to cleaning up kdewebkit and making it
> > ready for kdereview.
> 
> Why have you put everything into one file? I prefer one public class per
>  file. Otherwise I agree with your patch.

Because the two classes are related enough to one another and as such grouping 
them into one file seemed logical. It also reduces the number of header files 
one has to include to do KIO integration and we do not have to worry about 
what name to use for the file as we did with the class. I also thought that 
doing it this way would make it easier to have this change included into the 
next 4.3 release. Anyhow, to me creating separate files for such trivial 
classes does not seem necessary, but I have no preference about this one way 
or the other...

BTW, we need to prevent knetworkcookiejar.h from being installed in kdewebkit 
since it is going to be moved to KIO. It needs to be an internal class until 
then...