[WebKit-devel] KDE WebKit status update [Remix]

[Dawit A.]

On Thursday 15 October 2009 11:36:26 Michael Howell wrote:
> On Wednesday 14 October 2009 23:46:52 Dawit A. wrote:
> > On Wednesday 14 October 2009 19:23:32 Dawit A. wrote:
> > > > And yeah, for BC, you need to do the typedef as Michael suggested
> > > > (IHMO).
> > >
> > > Sorry, but "typedef AccessManager KDENetworkIntegration::AccessManager"
> > >  will not even compile simply because AccessManager does not exist.
> > > Perhaps you both confused the typdef syntax with the #define one ?? Or
> > > maybe I misunderstood something here ??
> >
> > Well I just tried to do the above and the typedef I proposed is neither
> > BC not SC due to missing moc symbols! And I think I now understand what
> > you both were saying. Leave KIO::AccessManager as is for BC/SC but
> > provide the above typedef for it, right ? Of course ;) Anyhow, that will
> > work fine as well... _______________________________________________
> > WebKit-devel mailing list
> > WebKit-devel at kde.org
> > https://mail.kde.org/mailman/listinfo/webkit-devel
> 
> class AccessManager {
> ...
> };
> namespace NetworkIntegration {
> typedef KIO::AccessManager AccessManager;
> ...
> }

That is exactly what I did... I guess I will create a reviewboard request to 
get this included for 4.3.3 since the patch is trivial enough addition, but of 
a great deal help to cleaning up kdewebkit and making it ready for kdereview.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: accessmanager.patch
Type: text/x-patch
Size: 9446 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/webkit-devel/attachments/20091015/ac27181c/attachment.patch