[WebKit-devel] Zoom actions change proposal (patch)

[Paweł Prażak]

On Sat, May 2, 2009 at 10:25 PM, Urs Wolfer <uwolfer at kde.org> wrote:

> On Saturday 02 May 2009 17:47:40 Paweł Prażak wrote:
> > Hi!
> >
> > I found some room for improvements in zoom actions.
> >
> > Essentially I propose to add the ability to change between text only and
> > whole page zoom modes (like "Zoom Text Only" option  in FF).
> >
> > I attach the patch with proposed changes.
> >
> > There are 3 small irrelevant intendation cleanup changes, I hope it's OK,
> > if not I can clean up the patch and resend.
> >
> > I'm little confused about the style, I've tried to use style of the
> > surrounding code, but I'm not sure if I did it right, sorry about that.
> > What style should be used in the webkitkde code?
>
> Hi Paweł
>
> Thanks for your patch! It looks basically good to me. Some comments:
> #1: Please create two patches: one for the code style fixes, and one for
> the
> functional changes.


Done. I've added astyle script as well (and runned in on the code). I'm not
sure if you want that big changes (>1000 LOC), but to make it simpler to
merge this commit with some uncommited changes out there, one can apply
script first and then merge :)

#2: Please make sure things still build with Qt 4.4, since this code shoul
> still build against stable kdelibs. I have not checked, but I'm not sure if
> you have paid attention to that.


I thought I had but when I've checked it turned out I didn't ;)
Anyway I've made some further improvements and removed enlarge/shrink
actions as they are redundant.

About the coding style: basically we use kdelibs coding style (see techbase
> for a documentation, though webkitsettings.{cpp,h} is a file copied from
> KHTML
> and thus uses (used) that coding style.. Please use kdelibs coding style
> for
> new code.


I've configured astyle to use kdelibs style.

Best Regards,
Paweł
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/webkit-devel/attachments/20090503/7afe379f/attachment-0001.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Intendation-cleanup.patch
Type: text/x-patch
Size: 3221 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/webkit-devel/attachments/20090503/7afe379f/attachment-0004.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Zoom-actions-changes.patch
Type: text/x-patch
Size: 8055 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/webkit-devel/attachments/20090503/7afe379f/attachment-0005.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Code-cleanup.patch
Type: text/x-patch
Size: 31238 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/webkit-devel/attachments/20090503/7afe379f/attachment-0006.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Added-astyle-script-for-kdelibs-style.-Applyed-sctip.patch
Type: text/x-patch
Size: 90896 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/webkit-devel/attachments/20090503/7afe379f/attachment-0007.patch