<br><br><div class="gmail_quote">On Sat, May 2, 2009 at 10:25 PM, Urs Wolfer <span dir="ltr"><<a href="mailto:uwolfer@kde.org">uwolfer@kde.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div><div></div><div class="h5">On Saturday 02 May 2009 17:47:40 Paweł Prażak wrote:<br>
> Hi!<br>
><br>
> I found some room for improvements in zoom actions.<br>
><br>
> Essentially I propose to add the ability to change between text only and<br>
> whole page zoom modes (like "Zoom Text Only" option in FF).<br>
><br>
> I attach the patch with proposed changes.<br>
><br>
> There are 3 small irrelevant intendation cleanup changes, I hope it's OK,<br>
> if not I can clean up the patch and resend.<br>
><br>
> I'm little confused about the style, I've tried to use style of the<br>
> surrounding code, but I'm not sure if I did it right, sorry about that.<br>
> What style should be used in the webkitkde code?<br>
<br>
</div></div>Hi Paweł<br>
<br>
Thanks for your patch! It looks basically good to me. Some comments:<br>
#1: Please create two patches: one for the code style fixes, and one for the<br>
functional changes.</blockquote><div><br>Done. I've added astyle script as well (and runned in on the code). I'm not sure if you want that big changes (>1000 LOC), but to make it simpler to merge this commit with some uncommited changes out there, one can apply script first and then merge :)<br>
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
#2: Please make sure things still build with Qt 4.4, since this code shoul<br>
still build against stable kdelibs. I have not checked, but I'm not sure if<br>
you have paid attention to that.</blockquote><div><br>I thought I had but when I've checked it turned out I didn't ;)<br>Anyway I've made some further improvements and removed enlarge/shrink actions as they are redundant. <br>
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
About the coding style: basically we use kdelibs coding style (see techbase<br>
for a documentation, though webkitsettings.{cpp,h} is a file copied from KHTML<br>
and thus uses (used) that coding style.. Please use kdelibs coding style for<br>
new code.</blockquote><div> <br>I've configured astyle to use kdelibs style.<br><br>Best Regards,<br>Paweł<br></div></div>