[WebKit-devel] Zoom actions change proposal (patch)

[Urs Wolfer]

On Saturday 02 May 2009 17:47:40 Paweł Prażak wrote:
> Hi!
>
> I found some room for improvements in zoom actions.
>
> Essentially I propose to add the ability to change between text only and
> whole page zoom modes (like "Zoom Text Only" option  in FF).
>
> I attach the patch with proposed changes.
>
> There are 3 small irrelevant intendation cleanup changes, I hope it's OK,
> if not I can clean up the patch and resend.
>
> I'm little confused about the style, I've tried to use style of the
> surrounding code, but I'm not sure if I did it right, sorry about that.
> What style should be used in the webkitkde code?

Hi Paweł

Thanks for your patch! It looks basically good to me. Some comments:
#1: Please create two patches: one for the code style fixes, and one for the 
functional changes.
#2: Please make sure things still build with Qt 4.4, since this code shoul 
still build against stable kdelibs. I have not checked, but I'm not sure if 
you have paid attention to that.

About the coding style: basically we use kdelibs coding style (see techbase 
for a documentation, though webkitsettings.{cpp,h} is a file copied from KHTML 
and thus uses (used) that coding style.. Please use kdelibs coding style for 
new code.

Bye
urs
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/webkit-devel/attachments/20090502/53dd2bd8/attachment.sig