[umbrello-devel] frameworks-GSoc review
Lays Rodrigues
laysrodriguessilva at gmail.com
Wed Jul 27 20:29:34 UTC 2016
On Wed, Jul 27, 2016 at 11:03 AM, Jonathan Riddell <jr at jriddell.org> wrote:
>
> Looking nice. Issues I still found
>
> In Class -> Attributes the Type Modifier field doesn't get restored in
> close/open, rather it becomes part of the Type.
>
Thinking in the best solution for fix it.
>
> In Templates -> Type if I set the type to a free form text values of
> say "asdf" then it gets reset back to class on close/open.
>
Well this is a bug, that isn't my fault. Filled a bug report:
https://bugs.kde.org/show_bug.cgi?id=366181
I will try to fix it.
>
> In Entity diagram -> Entity Attributes -> if I edit the stereotype
> name to something freeform "asdf1234" then it doesn't get saved on
> close/reopen.
>
Same thing that the previous item.
My guess: Ralf was removing some code from some classes and rewriting in
the DataTypeWidget that is the base for the types in umbrello, but that
could leaved inconsistences
in others parts of the code.
I think that the solution is only add the
object->setType(type). Where type is a UMLClassifier... But don't know if
I'm right. I'm basing this on the applyAttribute() in DataTypeWidget class;
I did that to fix the applyTemplate, the diff is this one:
https://paste.kde.org/ptzwemyad
I couldn't upload to reviewboard... dont know why.
> Nearly there :)
>
> Jonathan
>
>
>
> On Tue, Jul 26, 2016 at 01:16:01PM -0300, Lays Rodrigues wrote:
> >
> >
> > On Tue, Jul 26, 2016 at 8:01 AM, Jonathan Riddell <jr at jriddell.org>
> wrote:
> >
> > Still some issues in this:
> >
> > General Settings page:
> > - No Stereotype label
> >
> > Fixed
> >
> >
> > Attribute Dialog:
> > - Type Modifier and Initial Value and Type Qualifiers are not
> > restored on close/open of dialogue, instead they are stored in the
> >
> > Type field
> >
> > Yeah... I need to think more about this solution...
> >
> >
> >
> >
> > - Visibility isn't restored on open/close
> >
> > Fixed
> >
> >
> > - Classifier Scope isn't restored on open/close
> >
> > Fixed
> >
> >
> > Operation Dialog:
> > - Type and Visibility not stored
> >
> > Fixed
> >
> >
> > Paramater Properties Dialog:
> > - Two of the fields have no labels
> >
> > Fixed - But I need to make new alignment for the labels... re-write in
> an Ui
> > file - in the future =D
> >
> >
> >
> > Template Dialog:
> > - name is not pre-filled
> > - Name isn't restored on close/reopen
> >
> > Fixed
> >
> >
> >
> > Entity Relationship General Settings Page:
> > - Stereotype has no label
> > - Visiblity isn't restored on close/reopen
> >
> > Fixed
> >
> >
> > Entitle Attribute Properties Dialog:
> > - Indexing isn't restored on close/reopen
> >
> > Fixed
> >
> >
> >
> > Jonathan
> >
> >
> >
> > On 25 July 2016 at 23:49, Lays Rodrigues <
> laysrodriguessilva at gmail.com>
> > wrote:
> > >
> > >
> > > On Mon, Jul 25, 2016 at 8:51 AM, Jonathan Riddell <jr at jriddell.org
> >
> > wrote:
> > >>
> > >> Thanks for the updates. Issues I can see
> > >>
> > >> Attributes dialogue:
> > >> - name not pre-filled and it loses the name after a close/open
> > >>
> > >
> > > Fixed
> > >
> > >>
> > >> - Type: label isn't in line with Name: label
> > >
> > > Followin the documentation that you sent to me of KDE VDG, that is
> the
> > way
> > > that I need to align labels of anothers widgets
> > >
> > >>
> > >> - Initial value is lost after close/reopen
> > >
> > > Fixed
> > >
> > >>
> > >> Operation dialogue:
> > >> - values are lost when close/reopen for Type, Name and the
> checkboxes
> > >
> > > Fixed
> > >
> > >>
> > >> Template dialgoue:
> > >> - Name is lost on close/reopen
> > >
> > > Fixed
> > >
> > >>
> > >> General Page of class dialogue:
> > >> - Stereotype name label has disappeared and combobox is not
> editabl
> > >> e
> > >>
> > >>
> > >> Entity General Page
> > >> - As above, Stereotype name label has disappeared and combobox
> is not
> > >> editable
> > >
> > > Need to re-write
> > > both
> > > class
> > > es
> > > using an ui file.
> > >
> > >>
> > >> Entitle Attribute Dialogue
> > >> - Name, Default Value, Length lose values on close/open
> > >
> > > Fixed
> > >
> > >>
> > >> - stereotype isn't editable
> > >
> > > Fixed
> > >
> > >>
> > >>
> > >> Jonathan
> > >>
> > >>
> > >> On 22 July 2016 at 15:39, Lays Rodrigues <
> laysrodriguessilva at gmail.com>
> > >> wrote:
> > >> > Looks odd, but is need it. Because you can't combine mutable
> with
> > const
> > >> > or
> > >> > volatile. And that is the why of using this two widgets.
> > >> > http://en.cppreference.com/w/cpp/language/cv
> > >> >
> > >> > On Fri, Jul 22, 2016 at 11:24 AM, Jonathan Riddell <
> jr at jriddell.org>
> > >> > wrote:
> > >> >>
> > >> >> Thomas Pfeiffer
> > >> >> Oh and why does the "Type Qualifiers" box contain a mix of
> radio
> > >> >> buttons
> > >> >> and checkboxes? That is really odd
> > >> >> _______________________________________________
> > >> >> umbrello-devel mailing list
> > >> >> umbrello-devel at kde.org
> > >> >> https://mail.kde.org/mailman/listinfo/umbrello-devel
> > >> >
> > >> >
> > >> >
> > >> >
> > >> > --
> > >> > --
> > >> > Lays Rodrigues
> > >> > Front End Developer at Br-Print3D
> > >> > Computer Science Student at Federal Fluminense University
> > >> > brprint3d.wordpress.com
> > >> > laysrodriguesdev.wordpress.com
> > >> > fb.com/laysrodrigues147
> > >> > Telegram @lays147
> > >> > IRC lays147
> > >> >
> > >> >
> > >> > _______________________________________________
> > >> > umbrello-devel mailing list
> > >> > umbrello-devel at kde.org
> > >> > https://mail.kde.org/mailman/listinfo/umbrello-devel
> > >> >
> > >> _______________________________________________
> > >> umbrello-devel mailing list
> > >> umbrello-devel at kde.org
> > >> https://mail.kde.org/mailman/listinfo/umbrello-devel
> > >
> > >
> > >
> > >
> > > --
> > > --
> > > Lays Rodrigues
> > > Front End Developer at Br-Print3D
> > > Computer Science Student at Federal Fluminense University
> > > brprint3d.wordpress.com
> > > laysrodriguesdev.wordpress.com
> > > fb.com/laysrodrigues147
> > > Telegram @lays147
> > > IRC lays147
> > >
> > >
> > > _______________________________________________
> > > umbrello-devel mailing list
> > > umbrello-devel at kde.org
> > > https://mail.kde.org/mailman/listinfo/umbrello-devel
> > >
> > _______________________________________________
> > umbrello-devel mailing list
> > umbrello-devel at kde.org
> > https://mail.kde.org/mailman/listinfo/umbrello-devel
> >
> >
> >
> >
> > --
> > --
> > Lays Rodrigues
> > Front End Developer at Br-Print3D
> > Computer Science Student at Federal Fluminense University
> > brprint3d.wordpress.com
> > laysrodriguesdev.wordpress.com
> > fb.com/laysrodrigues147
> > Telegram @lays147
> > IRC lays147
> >
>
> > _______________________________________________
> > umbrello-devel mailing list
> > umbrello-devel at kde.org
> > https://mail.kde.org/mailman/listinfo/umbrello-devel
>
> _______________________________________________
> umbrello-devel mailing list
> umbrello-devel at kde.org
> https://mail.kde.org/mailman/listinfo/umbrello-devel
>
--
*Lays Rodrigues*
*Software Developer at KDE and Br-Print3D*
*Computer Science Student at Federal Fluminense University*
*brprint3d.wordpress.com <http://brprint3d.wordpress.com>*
*laysrodriguesdev.wordpress.com <http://laysrodriguesdev.wordpress.com>*
*fb.com/laysrodrigues147 <http://fb.com/laysrodrigues147>*
*Telegram @lays147*
*IRC lays147*
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/umbrello-devel/attachments/20160727/b4a37de2/attachment-0001.html>
More information about the umbrello-devel
mailing list