<div dir="ltr"><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jul 27, 2016 at 11:03 AM, Jonathan Riddell <span dir="ltr"><<a href="mailto:jr@jriddell.org" target="_blank">jr@jriddell.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><br>
Looking nice. Issues I still found<br>
<br>
In Class -> Attributes the Type Modifier field doesn't get restored in<br>
close/open, rather it becomes part of the Type.<br></blockquote><div><div class="gmail_default" style="font-size:small;display:inline">Thinking in the best solution for fix it.</div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
<br>
In Templates -> Type if I set the type to a free form text values of<br>
say "asdf" then it gets reset back to class on close/open.<br></blockquote><div><div class="gmail_default" style="font-size:small;display:inline">Well this is a bug, that isn't my fault. Filled a bug report: <a href="https://bugs.kde.org/show_bug.cgi?id=366181">https://bugs.kde.org/show_bug.cgi?id=366181</a></div></div><div><div class="gmail_default" style="font-size:small;display:inline">I will try to fix it.</div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
<br>
In Entity diagram -> Entity Attributes -> if I edit the stereotype<br>
name to something freeform "asdf1234" then it doesn't get saved on<br>
close/reopen.<br></blockquote><div><div class="gmail_default" style="font-size:small;display:inline">Same thing that the previous item.</div></div><div><div class="gmail_default" style="display:inline"><br></div></div><div><div class="gmail_default" style="display:inline">My guess: Ralf was removing some code from some classes and rewriting in the DataTypeWidget that is the base for the types in umbrello, but that could leaved inconsistences </div><div class="gmail_default" style="display:inline">in others parts of the code.</div></div><div><div class="gmail_default" style="display:inline">I think that the solution is only add the </div>object->setType(type). Where type is a UMLClassifier... But don't know if I'm right. I'm basing this on the applyAttribute() in DataTypeWidget class;<div class="gmail_default" style="font-size:small;display:inline"> </div></div><div><div class="gmail_default" style="font-size:small;display:inline"><br></div></div><div><div class="gmail_default" style="font-size:small;display:inline">I did that to fix the applyTemplate, the diff is this one: <a href="https://paste.kde.org/ptzwemyad">https://paste.kde.org/ptzwemyad</a></div></div><div><div class="gmail_default" style="font-size:small;display:inline">I couldn't upload to reviewboard... dont know why.</div></div><div><div class="gmail_default" style="display:inline"><br></div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
<br>
Nearly there :)<br>
<span><font color="#888888"><br>
Jonathan<br>
</font></span><div><div><br>
<br>
<br>
On Tue, Jul 26, 2016 at 01:16:01PM -0300, Lays Rodrigues wrote:<br>
><br>
><br>
> On Tue, Jul 26, 2016 at 8:01 AM, Jonathan Riddell <<a href="mailto:jr@jriddell.org" target="_blank">jr@jriddell.org</a>> wrote:<br>
><br>
> Still some issues in this:<br>
><br>
> General Settings page:<br>
> - No Stereotype label<br>
><br>
> Fixed<br>
> <br>
><br>
> Attribute Dialog:<br>
> - Type Modifier and Initial Value and Type Qualifiers are not<br>
> restored on close/open of dialogue, instead they are stored in the<br>
> <br>
> Type field<br>
><br>
> Yeah... I need to think more about this solution...<br>
> <br>
> <br>
><br>
> <br>
> - Visibility isn't restored on open/close <br>
><br>
> Fixed<br>
> <br>
><br>
> - Classifier Scope isn't restored on open/close<br>
><br>
> Fixed<br>
> <br>
><br>
> Operation Dialog:<br>
> - Type and Visibility not stored<br>
><br>
> Fixed<br>
> <br>
><br>
> Paramater Properties Dialog:<br>
> - Two of the fields have no labels<br>
><br>
> Fixed - But I need to make new alignment for the labels... re-write in an Ui<br>
> file - in the future =D<br>
> <br>
> <br>
><br>
> Template Dialog:<br>
> - name is not pre-filled<br>
> - Name isn't restored on close/reopen<br>
><br>
> Fixed<br>
> <br>
><br>
><br>
> Entity Relationship General Settings Page:<br>
> - Stereotype has no label<br>
> - Visiblity isn't restored on close/reopen<br>
><br>
> Fixed<br>
> <br>
><br>
> Entitle Attribute Properties Dialog:<br>
> - Indexing isn't restored on close/reopen<br>
><br>
> Fixed<br>
> <br>
><br>
><br>
> Jonathan<br>
><br>
><br>
><br>
> On 25 July 2016 at 23:49, Lays Rodrigues <<a href="mailto:laysrodriguessilva@gmail.com" target="_blank">laysrodriguessilva@gmail.com</a>><br>
> wrote:<br>
> ><br>
> ><br>
> > On Mon, Jul 25, 2016 at 8:51 AM, Jonathan Riddell <<a href="mailto:jr@jriddell.org" target="_blank">jr@jriddell.org</a>><br>
> wrote:<br>
> >><br>
> >> Thanks for the updates. Issues I can see<br>
> >><br>
> >> Attributes dialogue:<br>
> >> - name not pre-filled and it loses the name after a close/open<br>
> >><br>
> ><br>
> > Fixed<br>
> ><br>
> >><br>
> >> - Type: label isn't in line with Name: label<br>
> ><br>
> > Followin the documentation that you sent to me of KDE VDG, that is the<br>
> way<br>
> > that I need to align labels of anothers widgets<br>
> ><br>
> >><br>
> >> - Initial value is lost after close/reopen<br>
> ><br>
> > Fixed<br>
> ><br>
> >><br>
> >> Operation dialogue:<br>
> >> - values are lost when close/reopen for Type, Name and the checkboxes<br>
> ><br>
> > Fixed<br>
> ><br>
> >><br>
> >> Template dialgoue:<br>
> >> - Name is lost on close/reopen<br>
> ><br>
> > Fixed<br>
> ><br>
> >><br>
> >> General Page of class dialogue:<br>
> >> - Stereotype name label has disappeared and combobox is not editabl<br>
> >> e<br>
> >><br>
> >><br>
> >> Entity General Page<br>
> >> - As above, Stereotype name label has disappeared and combobox is not<br>
> >> editable<br>
> ><br>
> > Need to re-write<br>
> > both<br>
> > class<br>
> > es<br>
> > using an ui file.<br>
> ><br>
> >><br>
> >> Entitle Attribute Dialogue<br>
> >> - Name, Default Value, Length lose values on close/open<br>
> ><br>
> > Fixed<br>
> ><br>
> >><br>
> >> - stereotype isn't editable<br>
> ><br>
> > Fixed<br>
> ><br>
> >><br>
> >><br>
> >> Jonathan<br>
> >><br>
> >><br>
> >> On 22 July 2016 at 15:39, Lays Rodrigues <<a href="mailto:laysrodriguessilva@gmail.com" target="_blank">laysrodriguessilva@gmail.com</a>><br>
> >> wrote:<br>
> >> > Looks odd, but is need it. Because you can't combine mutable with<br>
> const<br>
> >> > or<br>
> >> > volatile. And that is the why of using this two widgets.<br>
> >> > <a href="http://en.cppreference.com/w/cpp/language/cv" rel="noreferrer" target="_blank">http://en.cppreference.com/w/cpp/language/cv</a><br>
> >> ><br>
> >> > On Fri, Jul 22, 2016 at 11:24 AM, Jonathan Riddell <<a href="mailto:jr@jriddell.org" target="_blank">jr@jriddell.org</a>><br>
> >> > wrote:<br>
> >> >><br>
> >> >> Thomas Pfeiffer<br>
> >> >> Oh and why does the "Type Qualifiers" box contain a mix of radio<br>
> >> >> buttons<br>
> >> >> and checkboxes? That is really odd<br>
> >> >> _______________________________________________<br>
> >> >> umbrello-devel mailing list<br>
> >> >> <a href="mailto:umbrello-devel@kde.org" target="_blank">umbrello-devel@kde.org</a><br>
> >> >> <a href="https://mail.kde.org/mailman/listinfo/umbrello-devel" rel="noreferrer" target="_blank">https://mail.kde.org/mailman/listinfo/umbrello-devel</a><br>
> >> ><br>
> >> ><br>
> >> ><br>
> >> ><br>
> >> > --<br>
> >> > --<br>
> >> > Lays Rodrigues<br>
> >> > Front End Developer at Br-Print3D<br>
> >> > Computer Science Student at Federal Fluminense University<br>
> >> > <a href="http://brprint3d.wordpress.com" rel="noreferrer" target="_blank">brprint3d.wordpress.com</a><br>
> >> > <a href="http://laysrodriguesdev.wordpress.com" rel="noreferrer" target="_blank">laysrodriguesdev.wordpress.com</a><br>
> >> > <a href="http://fb.com/laysrodrigues147" rel="noreferrer" target="_blank">fb.com/laysrodrigues147</a><br>
> >> > Telegram @lays147<br>
> >> > IRC lays147<br>
> >> ><br>
> >> ><br>
> >> > _______________________________________________<br>
> >> > umbrello-devel mailing list<br>
> >> > <a href="mailto:umbrello-devel@kde.org" target="_blank">umbrello-devel@kde.org</a><br>
> >> > <a href="https://mail.kde.org/mailman/listinfo/umbrello-devel" rel="noreferrer" target="_blank">https://mail.kde.org/mailman/listinfo/umbrello-devel</a><br>
> >> ><br>
> >> _______________________________________________<br>
> >> umbrello-devel mailing list<br>
> >> <a href="mailto:umbrello-devel@kde.org" target="_blank">umbrello-devel@kde.org</a><br>
> >> <a href="https://mail.kde.org/mailman/listinfo/umbrello-devel" rel="noreferrer" target="_blank">https://mail.kde.org/mailman/listinfo/umbrello-devel</a><br>
> ><br>
> ><br>
> ><br>
> ><br>
> > --<br>
> > --<br>
> > Lays Rodrigues<br>
> > Front End Developer at Br-Print3D<br>
> > Computer Science Student at Federal Fluminense University<br>
> > <a href="http://brprint3d.wordpress.com" rel="noreferrer" target="_blank">brprint3d.wordpress.com</a><br>
> > <a href="http://laysrodriguesdev.wordpress.com" rel="noreferrer" target="_blank">laysrodriguesdev.wordpress.com</a><br>
> > <a href="http://fb.com/laysrodrigues147" rel="noreferrer" target="_blank">fb.com/laysrodrigues147</a><br>
> > Telegram @lays147<br>
> > IRC lays147<br>
> ><br>
> ><br>
> > _______________________________________________<br>
> > umbrello-devel mailing list<br>
> > <a href="mailto:umbrello-devel@kde.org" target="_blank">umbrello-devel@kde.org</a><br>
> > <a href="https://mail.kde.org/mailman/listinfo/umbrello-devel" rel="noreferrer" target="_blank">https://mail.kde.org/mailman/listinfo/umbrello-devel</a><br>
> ><br>
> _______________________________________________<br>
> umbrello-devel mailing list<br>
> <a href="mailto:umbrello-devel@kde.org" target="_blank">umbrello-devel@kde.org</a><br>
> <a href="https://mail.kde.org/mailman/listinfo/umbrello-devel" rel="noreferrer" target="_blank">https://mail.kde.org/mailman/listinfo/umbrello-devel</a><br>
><br>
><br>
><br>
><br>
> --<br>
> --<br>
> Lays Rodrigues<br>
> Front End Developer at Br-Print3D<br>
> Computer Science Student at Federal Fluminense University<br>
> <a href="http://brprint3d.wordpress.com" rel="noreferrer" target="_blank">brprint3d.wordpress.com</a><br>
> <a href="http://laysrodriguesdev.wordpress.com" rel="noreferrer" target="_blank">laysrodriguesdev.wordpress.com</a><br>
> <a href="http://fb.com/laysrodrigues147" rel="noreferrer" target="_blank">fb.com/laysrodrigues147</a><br>
> Telegram @lays147<br>
> IRC lays147<br>
><br>
<br>
> _______________________________________________<br>
> umbrello-devel mailing list<br>
> <a href="mailto:umbrello-devel@kde.org" target="_blank">umbrello-devel@kde.org</a><br>
> <a href="https://mail.kde.org/mailman/listinfo/umbrello-devel" rel="noreferrer" target="_blank">https://mail.kde.org/mailman/listinfo/umbrello-devel</a><br>
<br>
_______________________________________________<br>
umbrello-devel mailing list<br>
<a href="mailto:umbrello-devel@kde.org" target="_blank">umbrello-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/umbrello-devel" rel="noreferrer" target="_blank">https://mail.kde.org/mailman/listinfo/umbrello-devel</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div><b style="font-size:12.8px"><font color="#000000">Lays Rodrigues</font></b><br></div><div><b><font style="background-color:rgb(255,255,255)" color="#000000">Software Developer at KDE and Br-Print3D</font></b></div><div><b><font style="background-color:rgb(255,255,255)" color="#000000">Computer Science Student at Federal Fluminense University</font></b></div><div><b><font style="background-color:rgb(255,255,255)" color="#000000"><a href="http://brprint3d.wordpress.com" style="background-color:rgb(255,255,255)" target="_blank">brprint3d.wordpress.com</a></font></b></div><div><b><a href="http://laysrodriguesdev.wordpress.com" target="_blank"><font color="#000000">laysrodriguesdev.wordpress.com</font></a></b></div><div><b><a href="http://fb.com/laysrodrigues147" style="background-color:rgb(255,255,255)" target="_blank"><font color="#000000">fb.com/laysrodrigues147</font></a></b></div><div><b><font style="background-color:rgb(255,255,255)" color="#000000">Telegram @lays147</font></b></div><div><b><font style="background-color:rgb(255,255,255)" color="#000000">IRC lays147</font></b></div><div><br></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div>
</div></div>