[umbrello-devel] Debian valgrind patch

[Ralf Habacker]

Am 08.06.2015 um 05:56 schrieb Jonathan Riddell:
> I just noticed debian have added a patch which now doesn't apply
>
> http://anonscm.debian.org/cgit/pkg-kde/applications/umbrello.git/tree/debian/patches/valgrind_errors
This patch  consist of several combined valgrind reported issues.

++ // valgrind issue:
++ // Conditional jump or move depends on uninitialised value(s)
++ // setVisualPropertyCmd(ShowVisibility, ops.classState.showVisibility);
++ // uses m_operationSignature

has been fixed with KDE 4.8
(http://commits.kde.org/umbrello/76fa78b53df360764e389fafa40e93737dddb8e5)

++ // valgrind error
++ // segfault after a failed paste and then try to select an
++ // area

fixed with version 4.12  (undo refactoring  by Joris Steyn)


+Index: umbrello/umbrello/umlscene.cpp
+===================================================================
+--- umbrello.orig/umbrello/umlscene.cpp 2014-07-23 19:26:14.001327214 +0200
++++ umbrello/umbrello/umlscene.cpp 2014-07-23 19:26:39.080329543 +0200
+@@ -1221,8 +1221,8 @@
+ disconnect(this, SIGNAL(sigTextColorChanged(Uml::ID::Type)), o,
SLOT(slotTextColorChanged(Uml::ID::Type)));
+ if (t == WidgetBase::wt_Message) {
+ m_MessageList.removeAll(static_cast<MessageWidget*>(o));
+- } else
+- m_WidgetList.removeAll(o);
++ }
++ m_WidgetList.removeAll(o);
+ o->deleteLater();
+ m_doc->setModified(true);
+ }

no idea what kind of bug should be fixed with this patch  - messages are
hold in the message list not in the widget list

++ // segfault on click after removing the assoc
++ // m_scene->addFloatingTextWidget(ft);

how to reproduce this bug ?

|

+    // Wait till be have the complete object loaded to propagate
+    // signals and sync to model.|

What kind of bug should be fixed with this hunk ?
>
> it's from this bug
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=610504
>
> could it be merged upstream or else let me know if I can drop it?
The first two hunks of the patch could be dropped, the remaining needs
more explanation to be able to decide if they are obsolate or not.

Regards

Ralf
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/umbrello-devel/attachments/20150608/ce2a3144/attachment.html>