<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Am 08.06.2015 um 05:56 schrieb Jonathan
Riddell:<br>
</div>
<blockquote
cite="mid:CANX=XXMuo8Kc0fqkAiM-t7cC4X71JkEo3DZ=jVvgAn8ZxiVzww@mail.gmail.com"
type="cite">
<pre wrap="">I just noticed debian have added a patch which now doesn't apply
<a class="moz-txt-link-freetext" href="http://anonscm.debian.org/cgit/pkg-kde/applications/umbrello.git/tree/debian/patches/valgrind_errors">http://anonscm.debian.org/cgit/pkg-kde/applications/umbrello.git/tree/debian/patches/valgrind_errors</a></pre>
</blockquote>
This patch consist of several combined valgrind reported issues.<br>
<br>
<div class="add">++ // valgrind issue:</div>
<div class="add">++ // Conditional jump or move depends on
uninitialised value(s)</div>
<div class="add">++ // setVisualPropertyCmd(ShowVisibility,
ops.classState.showVisibility);</div>
<div class="add">++ // uses m_operationSignature</div>
<br>
has been fixed with KDE 4.8
(<a class="moz-txt-link-freetext" href="http://commits.kde.org/umbrello/76fa78b53df360764e389fafa40e93737dddb8e5">http://commits.kde.org/umbrello/76fa78b53df360764e389fafa40e93737dddb8e5</a>)<br>
<br>
<div class="add">++ // valgrind error</div>
<div class="add">++ // segfault after a failed paste and then try to
select an</div>
<div class="add">++ // area</div>
<br>
fixed with version 4.12 (undo refactoring by Joris Steyn)<br>
<br>
<br>
<div class="add">+Index: umbrello/umbrello/umlscene.cpp</div>
<div class="add">+===================================================================</div>
<div class="add">+--- umbrello.orig/umbrello/umlscene.cpp 2014-07-23
19:26:14.001327214 +0200</div>
<div class="add">++++ umbrello/umbrello/umlscene.cpp 2014-07-23
19:26:39.080329543 +0200</div>
<div class="add">+@@ -1221,8 +1221,8 @@</div>
<div class="add">+ disconnect(this,
SIGNAL(sigTextColorChanged(Uml::ID::Type)), o,
SLOT(slotTextColorChanged(Uml::ID::Type)));</div>
<div class="add">+ if (t == WidgetBase::wt_Message) {</div>
<div class="add">+
m_MessageList.removeAll(static_cast<MessageWidget*>(o));</div>
<div class="add">+- } else</div>
<div class="add">+- m_WidgetList.removeAll(o);</div>
<div class="add">++ }</div>
<div class="add">++ m_WidgetList.removeAll(o);</div>
<div class="add">+ o->deleteLater();</div>
<div class="add">+ m_doc->setModified(true);</div>
<div class="add">+ }</div>
<br>
no idea what kind of bug should be fixed with this patch - messages
are hold in the message list not in the widget list<br>
<br>
++ // segfault on click after removing the assoc
<div class="add">++ // m_scene->addFloatingTextWidget(ft);</div>
<br>
how to reproduce this bug ? <br>
<br>
<pre><code><pre>+ // Wait till be have the complete object loaded to propagate
+ // signals and sync to model.</pre></code></pre>
What kind of bug should be fixed with this hunk ?<br>
<blockquote
cite="mid:CANX=XXMuo8Kc0fqkAiM-t7cC4X71JkEo3DZ=jVvgAn8ZxiVzww@mail.gmail.com"
type="cite">
<pre wrap="">
it's from this bug
<a class="moz-txt-link-freetext" href="https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=610504">https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=610504</a>
could it be merged upstream or else let me know if I can drop it?</pre>
</blockquote>
The first two hunks of the patch could be dropped, the remaining
needs more explanation to be able to decide if they are obsolate or
not.<br>
<br>
Regards<br>
<br>
Ralf <br>
</body>
</html>